Sqlmodel #36
Merged
Sqlmodel #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Incomplete work toward splitting backend into classes * go back... * revert more * revert more * redo changes * backend work * file reporting works * file backend work * Fix typing import for python 3.10 #52 * Partial implementation of remove for file backend. #52 * Add check_which_results_exist and check_results_exist to file backend. #52 * Move check_results_exist to abstract class. #52 * Implement check_record_exists in file backend. #52 * Implement get_status and set_status in file backend. #52 * Implement clear_status in file backend. #52 * partial DBBackend report implementation. * continue DBBackend report implementation. * Implement retrieve for DBBackend. #52 * Implement removal for DBBackend. #52 * refactor check_record_exists and add to interface * refactor check_which_results_exist to list_existing_results * finish implementing remove for DB backend #52 * Add option to return all results for list_existing_results DB Backend * Add option to return all results for list_existing_results File Backend * consolidate report and report_db in DB Backend * create remove_record functions for file and DB backends * Add basic implementation for Pytesting new split classes. * remove unused decorator * simplify list results func * clarify docstring * rename to list_results * rename some variables * fix priority vars for check-result_exists * lint * simplify list_results for DB Backend by using list comprehension * extend basic testing for split_backend, fix remove_record to update local file * clean up report in pipestat manager, fix related pytests * clean up remove and retrieve * add pytest condition for DB backend * Implement select function #52 * Implement select_txt function #52 * ReImplement record_count function * Implement set_status * Implement get_status * Remove redundant code from pipestat.py * move select_distinct to DB backend. * remove redundant functions, clean up docstrings * add raising exception if no backend specified * Correct doc strings. * remove ".new" usage. * add PROJECT_NAME as constant * Clean up pipestat context managers. * lint * add some type hints. * implement require backend decorator * no need for intermediate variable * Change self[DATA_KEY] to self.data and align both parent and child classes to use attribute instead of attribute or item. * fix pytest assertion * replace status" with constant * Change backend data attribute to _data * Fix pipeline_type/table_name priority * Remove select functions from pipestatmanager parent class * Move initializing and loading results file to FileBackend. * Refactor namespace and project name to pipeline_name. * Refactor pipeline_id to pipeline_name, remove namespace property. * Organize functions * unify some properties retrievals * standardize retrieve function. Fix #58. * simplify field definitions, refactor namespace to project_name * use const in field definitions * Remove commented, unused code from backend * Add and edit docstrings * add some tests * move orm and engine creation to DB backend. * Split backend files for readability. * Clean up redundant importing, re-organize functions and properties --------- Co-authored-by: nsheff <nsheff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #35 from local branch