Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Authentification Database option when connect to mongo #139

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

etiennecoutaud
Copy link

I would like to be able to reproduce behaviour similar to mongo client flag : --authenticationDatabase

Associated mongo client documentation : https://docs.mongodb.com/manual/reference/program/mongo/#cmdoption-mongo-authenticationdatabase

If not setting, default will be an empty string and behaviour will be similar to the actual. Mongo will use the same database that defined in the connection string.

@it-percona
Copy link

it-percona commented Apr 17, 2019

CLA assistant check
All committers have signed the CLA.

@etiennecoutaud etiennecoutaud force-pushed the authentification-db branch 2 times, most recently from ef5c7ac to 0234d14 Compare April 17, 2019 17:04
@idexter
Copy link

idexter commented Apr 18, 2019

@etiennecoutaud Hi, thanks for the contribution.
Please run go test . -update then commit changed .golden file. It will fix tests and I'll merge it.

@etiennecoutaud
Copy link
Author

etiennecoutaud commented Apr 18, 2019

@dexterHD thanks for your reply,

go test . -update are green

I thinks its related to a newline, I rerun the tests

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #139 into master will increase coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #139      +/-   ##
=========================================
+ Coverage     8.8%   8.87%   +0.07%     
=========================================
  Files          36      36              
  Lines        2193    2197       +4     
=========================================
+ Hits          193     195       +2     
- Misses       1981    1983       +2     
  Partials       19      19
Impacted Files Coverage Δ
mongodb_exporter.go 28.57% <0%> (-0.94%) ⬇️
collector/mongodb_collector.go 64.78% <100%> (+0.16%) ⬆️
shared/connection.go 28.05% <100%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b9aa5...329743e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #139 into master will increase coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #139      +/-   ##
=========================================
+ Coverage     8.8%   8.87%   +0.07%     
=========================================
  Files          36      36              
  Lines        2193    2197       +4     
=========================================
+ Hits          193     195       +2     
- Misses       1981    1983       +2     
  Partials       19      19
Impacted Files Coverage Δ
mongodb_exporter.go 28.57% <0%> (-0.94%) ⬇️
collector/mongodb_collector.go 64.78% <100%> (+0.16%) ⬆️
shared/connection.go 28.05% <100%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b9aa5...329743e. Read the comment docs.

@idexter idexter merged commit ac28a7c into percona:master Apr 18, 2019
@etiennecoutaud
Copy link
Author

Thanks @dexterHD for the merge, any idea of when is the next release ?

@etiennecoutaud etiennecoutaud deleted the authentification-db branch April 18, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants