PMM-9450 Enable basic auth #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to be applied on top of #393 (the re-revert) and adds a new parameter, the tls-config-path file that should be sent by pmm-managed, pointing to a file containing the credentials we use to enable basic auth. In the original implementation, we use exporter_shared library which receives basic auth credentials via env vars. Now, using Prometheus Toolkit library, we need to pass a file.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
|
@percona-csalguero , please associate with a corresponding PR for PMM server. |
tshcherban
changed the title
This was referenced Apr 7, 2022
tshcherban
approved these changes
Apr 19, 2022
BupycHuk
approved these changes
Apr 21, 2022
JiriCtvrtka
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-9450
Build: PR-2424
pmm-managed: PR-979
Enable Basic Auth on new HTTP server
This is intended to be applied on top of serve metrics handler with prometheus exporter-toolkit #393 (the re-revert) and adds a
new parameter, the tls-config-path file that should be sent by
pmm-managed, pointing to a file containing the credentials we use to
enable basic auth.
In the original implementation, we use exporter_shared library which
receives basic auth credentials via env vars.
Now, using Prometheus Toolkit library, we need to pass a file.