serve metrics handler with prometheus exporter-toolkit #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
denisok
requested review from
a team,
percona-csalguero and
JiriCtvrtka
and removed request for
a team
|
Hi, Thanks. |
percona-csalguero
suggested changes
Dec 15, 2021
|
I really appreciate this PR. Using exporter shared was preventing us to implement some other features like SSL support. |
rlankfo
force-pushed
the
exporter-toolkit
branch
from
852a12d
to
bc153c9
Compare
percona-csalguero
approved these changes
Dec 16, 2021
|
@JiriCtvrtka please review |
JiriCtvrtka
approved these changes
Dec 30, 2021
| @@ -6,3 +6,4 @@ bin | |||
| build | |||
| dist | |||
| mongodb_exporter | |||
| vendor | |||
There was a problem hiding this comment.
This is not necessary since we dont have vendor folder anymore.
|
@percona-csalguero would test it a little bit more and merge it |
percona-csalguero
added a commit
that referenced
this pull request
Jan 11, 2022
This reverts commit cb94884.
denisok
pushed a commit
that referenced
this pull request
Jan 11, 2022
percona-csalguero
added a commit
that referenced
this pull request
Jan 11, 2022
This is intended to be applied on top of #393 (the re-revert) and adds a new parameter, the tls-config-path file that should be sent by pmm-managed, pointing to a file containing the credentials we use to enable basic auth. In the original implementation, we use exporter_shared library which receives basic auth credentials via env vars. Now, using Prometheus Toolkit library, we need to pass a file.
JiriCtvrtka
pushed a commit
that referenced
this pull request
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves the metrics handler utilizing
prometheus/exporter-toolkitinstead ofpercona/exporter_shared. This is a start towards fixing #319, at least partially, however this does not remove all references toexporter_shared.Note that TLS Config still needs to be handled by adding an option to pass the tlsConfigPath.
Once all checks pass and the code is ready for review, please add
pmm-review-exportersteam as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum or Discord.