-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serve metrics handler with prometheus exporter-toolkit #393
Conversation
Hi, Thanks. |
I really appreciate this PR. Using exporter shared was preventing us to implement some other features like SSL support. |
852a12d
to
bc153c9
Compare
@JiriCtvrtka please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM only one minor comment.
@@ -6,3 +6,4 @@ bin | |||
build | |||
dist | |||
mongodb_exporter | |||
vendor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not necessary since we dont have vendor folder anymore.
@percona-csalguero would test it a little bit more and merge it |
This reverts commit cb94884.
This is intended to be applied on top of #393 (the re-revert) and adds a new parameter, the tls-config-path file that should be sent by pmm-managed, pointing to a file containing the credentials we use to enable basic auth. In the original implementation, we use exporter_shared library which receives basic auth credentials via env vars. Now, using Prometheus Toolkit library, we need to pass a file.
This PR serves the metrics handler utilizing
prometheus/exporter-toolkit
instead ofpercona/exporter_shared
. This is a start towards fixing #319, at least partially, however this does not remove all references toexporter_shared
.Note that TLS Config still needs to be handled by adding an option to pass the tlsConfigPath.
Once all checks pass and the code is ready for review, please add
pmm-review-exporters
team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum or Discord.