-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/prometheus/common from 0.47.0 to 0.52.3 #2955
Merged
github-actions
merged 5 commits into
main
from
dependabot/go_modules/github.com/prometheus/common-0.52.3
Apr 21, 2024
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7501be8
Bump github.com/prometheus/common from 0.47.0 to 0.52.3
dependabot[bot] 4317ca6
PMM-7 Update percona/exporter_shared
BupycHuk 98ef39d
PMM-7 Update percona/exporter_shared
BupycHuk d90984c
Merge branch 'main' into dependabot/go_modules/github.com/prometheus/…
BupycHuk 1bd7aae
Merge branch 'main' into dependabot/go_modules/github.com/prometheus/…
idoqo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can drop the toolchain directive - less stuff to update on every new patch version release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't, you can see that CI failed because of not having that. By the last commit I had to re-add it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this is because we need to have the same Go version inside the image/container (i.e.
perconalab/pmm-server:dev-latest), which is not the case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, if we bump it up here, we have to use the same version everywhere, including the build tools, like
rpmbuild.In the logs I'm seeing an attempt to download go (
go: downloading go1.22 (linux/amd64), which should not be needed if we use the same version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great part about it that our build system started using go1.22 after merging this PR and nothing is broken.