Bump github.com/prometheus/common from 0.47.0 to 0.52.3 #2955
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
requested review from
ademidoff,
BupycHuk,
idoqo and
JiriCtvrtka
and removed request for
a team
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.47.0 to 0.52.3. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.47.0...v0.52.3) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/prometheus/common-0.52.3
branch
from
2b0e3f2
to
7501be8
Compare
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| toolchain go1.22.2 |
There was a problem hiding this comment.
We can drop the toolchain directive - less stuff to update on every new patch version release.
There was a problem hiding this comment.
we can't, you can see that CI failed because of not having that. By the last commit I had to re-add it back.
There was a problem hiding this comment.
I suppose this is because we need to have the same Go version inside the image/container (i.e. perconalab/pmm-server:dev-latest), which is not the case.
There was a problem hiding this comment.
IMO, if we bump it up here, we have to use the same version everywhere, including the build tools, like rpmbuild.
In the logs I'm seeing an attempt to download go (go: downloading go1.22 (linux/amd64), which should not be needed if we use the same version.
There was a problem hiding this comment.
great part about it that our build system started using go1.22 after merging this PR and nothing is broken.
|
A newer version of github.com/prometheus/common exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2955 +/- ##
=======================================
Coverage 42.27% 42.27%
=======================================
Files 396 397 +1
Lines 50123 50122 -1
=======================================
+ Hits 21188 21190 +2
+ Misses 26935 26930 -5
- Partials 2000 2002 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
deleted the
dependabot/go_modules/github.com/prometheus/common-0.52.3
branch
Bumps github.com/prometheus/common from 0.47.0 to 0.52.3.
Release notes
Sourced from github.com/prometheus/common's releases.
... (truncated)
Commits
0234594Add support for go 1.20 (#617)4433931Merge pull request #615 from prometheus/dependabot/go_modules/sigv4/github.co...728e910Merge pull request #616 from srebhan/fix_protobuf_decode78585cffix(protobuf): Correctly decode multi-messages streams5fef1dfBump github.com/aws/aws-sdk-go from 1.50.31 to 1.51.11 in /sigv43dec13cDrop support for Go older than 1.18 (#612)95edf51Update common Prometheus files (#613)e821827Retract v0.50.0 (#610)2807775Update common Prometheus files (#609)617b51dSynchronize common files from prometheus/prometheus (#606)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)