name for jre folder (its not a jdk) #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the general idea but (and I know we're starting to split hairs here) but the included runtime can be a jdk and not "only" a jre so the name might be misleading. What do you think about renaming this to a neutral This way all the Java specific resource would be located within the |
|
That would be good by me! |
|
The reason for the .jre is this extension is typical for jres downloaded for MacOS...for example zulu-17.jre etc. |
perdian
changed the base branch from
master
to
feature/rename-runtime-directory
|
Released to Maven Central as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR proposes to rename the folder the private JRE is placed. Currently its called jdk. Usually only JRE will be distributed. This PR renames the folder to Runtime.jre