Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert when Edit + Move #12

Open
swc-jesse opened this issue Nov 5, 2021 · 0 comments
Open

Assert when Edit + Move #12

swc-jesse opened this issue Nov 5, 2021 · 0 comments

Comments

@swc-jesse
Copy link

We have hit cases where files were moved within the current stream but also edited (seemingly to avoid compilation errors since the files are now in a new location). The steps to replicate this behavior seem to be:

  1. Open original file for Edit
  2. Move (Mark original file for delete)
  3. Make changes to the file (which is now Add / Edit)
  4. Submit

In replicating this change, p4transfer asserts:

2021-11-05 08:39:34,908:P4Transfer:ERROR:
Traceback (most recent call last):
  File "P4Transfer.py", line 2168, in replicate
    num_changes = self.replicate_changes()
  File "P4Transfer.py", line 1985, in replicate_changes
    targetChange = self.target.replicateChange(fileRevs, srcFileLogs, change, self.source.p4.port)
  File "P4Transfer.py", line 1234, in replicateChange
    self.processChangeRevs(fileRevs, srcFileLogs)
  File "P4Transfer.py", line 1189, in processChangeRevs
    self.replicateIntegration(f)
  File "P4Transfer.py", line 1636, in replicateIntegration
    assert(afterAdd)
AssertionError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant