-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perfsee github app will auto create compare in my closed issue #168
Comments
This is indeed a bug, the reason is that this commit is associated to a pull request (nonomal/tailchat#16) that does not belong to this repository, and our bot didn't expect this, and comments to the wrong issues (since github pull request and issues both use the number) We will fix this issue as soon as possible. |
👍 So in origin design, bot should do nothing? But another issue is, why app will found others folk? others not install perfsee app(maybe). |
Yes. In this case, bot should do nothing. We use the github check runs api to find pull requests, and it seems that it can find not only pr from fork to the sourece repo, but also pr from the source repo to fork. Since fork is public, this not have permission issues. But perfsee will limit the features to the repository where perfsee is installed and will not do anything to other repositories |
I get it, thanks for your reply. 💯 But my suggest is listen on webhook event. its means start work after app installed, check passed pr is not meaningful. |
perfsee
app will auto create compare in my closed issue after i upload my first bundle info.I dont think it is a right behaviour.
First, it is a issue, not pr.
Second, it has been closed.
It is a bug or feature?
Some reference:
The text was updated successfully, but these errors were encountered: