Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perfsee github app will auto create compare in my closed issue #168

Closed
moonrailgun opened this issue Oct 25, 2022 · 4 comments · Fixed by #174
Closed

perfsee github app will auto create compare in my closed issue #168

moonrailgun opened this issue Oct 25, 2022 · 4 comments · Fixed by #174
Assignees
Labels
bug Something isn't working

Comments

@moonrailgun
Copy link
Contributor

perfsee app will auto create compare in my closed issue after i upload my first bundle info.

I dont think it is a right behaviour.

First, it is a issue, not pr.

Second, it has been closed.

It is a bug or feature?

Some reference:

@moonrailgun moonrailgun changed the title perfsee app will auto create compare in my closed issue perfsee github app will auto create compare in my closed issue Oct 25, 2022
@forehalo forehalo added the bug Something isn't working label Oct 26, 2022
@EYHN
Copy link
Member

EYHN commented Oct 28, 2022

This is indeed a bug, the reason is that this commit is associated to a pull request (nonomal/tailchat#16) that does not belong to this repository, and our bot didn't expect this, and comments to the wrong issues (since github pull request and issues both use the number)

We will fix this issue as soon as possible.

@moonrailgun
Copy link
Contributor Author

moonrailgun commented Oct 28, 2022

👍

So in origin design, bot should do nothing?

But another issue is, why app will found others folk? others not install perfsee app(maybe).

@EYHN
Copy link
Member

EYHN commented Oct 28, 2022

Yes. In this case, bot should do nothing.

We use the github check runs api to find pull requests, and it seems that it can find not only pr from fork to the sourece repo, but also pr from the source repo to fork. Since fork is public, this not have permission issues.

But perfsee will limit the features to the repository where perfsee is installed and will not do anything to other repositories

@moonrailgun
Copy link
Contributor Author

I get it, thanks for your reply. 💯

But my suggest is listen on webhook event. its means start work after app installed, check passed pr is not meaningful.

@EYHN EYHN closed this as completed in #174 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

3 participants