Import list at /importer/ doesn't work with Go tip #1090
Comments
|
The error is: The html/template code is: var tmpl = template.Must(template.New("root").Funcs(map[string]interface{}{
"bloblink": func(br blob.Ref) string {
panic("should be overridden; this one won't be called")
},
}).Parse(`
{{define "pageTop"}}
<html>
<head>
<title>{{.Title}}</title>
</head>
<body>
<h1>{{.Title}}</h1>
{{end}}
{{define "pageBottom"}}
</body>
</html>
{{end}}
{{define "importersRootPage"}}
{{template "pageTop" .}}
{{template "importersRootBody" .Body}}
{{template "pageBottom"}}
{{end}}
{{define "importersRootBody"}}
<ul>
{{$base := .Host.ImporterBaseURL}}
{{range .Importers}}
<li><a href="{{$base}}{{.Name}}">{{.Name}}</a></li>
{{end}}
</ul>
{{end}}
....
`)I see @mvdan added https://go-review.googlesource.com/84480 ("text/template: add variable assignments") on Dec 2017 for Go 1.11 (tip), but it seems we were already using variable assignments? I'm confused. |
camlistorebot
pushed a commit
that referenced
this issue
Apr 17, 2018
Updates #1090 Change-Id: I16ee3cfd49ba9af2b98cdef470932ca000d768dc
|
Duplicate of golang/go#24791 Already fixed upstream. My Go binary was a bit too old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The URL /importer/ works when camlistored is build with Go 1.10, but I get a template error about missing
$basewhen I compile with Go tip.Investigate.
Maybe we're using template wrong, or maybe it's an upstream Go bug.
/cc @mpl
The text was updated successfully, but these errors were encountered: