Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perl::Critic being instantiated for each file is very slow #10

Closed
holcapek opened this issue Dec 14, 2017 · 2 comments
Closed

Perl::Critic being instantiated for each file is very slow #10

holcapek opened this issue Dec 14, 2017 · 2 comments

Comments

@holcapek
Copy link
Contributor

Not sure if this is intended or not, but instantiating Perl::Critic for each file to be criticized makes critic_ok pretty slow.

Running perlcritic upon set of files is roughly 4 times faster than Test::Perl::Critic.

Would it be possible to initialize Perl::Critic just once for all files?

Thanks!

@holcapek
Copy link
Contributor Author

holcapek commented Dec 14, 2017

Would something trivial like #11 work? I am not sure of consequences to all_critic_ok as it's using MCE.
In case you like the meaning but don't like the look, I can make it look more appealing, of course :-)

@petdance
Copy link
Member

Done. It's in the just-pushed-to-CPAN 1.04. Thanks for the nudge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants