Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test t/alien_base_modulebuild_repository_http.t fails on Windows 10, MSYS2 #19

Closed
hakonhagland opened this issue Jul 26, 2020 · 2 comments

Comments

@hakonhagland
Copy link

System info: Windows 10, MSYS2, perl version 5.32.2.

$ ./Build test
t/00_diag.t .................................. 1/? #
#
#
# HARNESS_ACTIVE=1
# HARNESS_VERSION=3.42
# LANG=en_US.UTF-8
# PERL5LIB=/home/hakon/perl/cpan-source/debug/Alien-Base-ModuleBuild-1.14/blib/lib:/home/hakon/perl/cpan-source/debug/Alien-Base-ModuleBuild-1.14/blib/arch
# PERL_DL_NONLAZY=1
# PERL_USE_UNSAFE_INC=1
# SHELL=/usr/bin/bash
#
#
#
# PERL5LIB path
# /home/hakon/perl/cpan-source/debug/Alien-Base-ModuleBuild-1.14/blib/lib
# /home/hakon/perl/cpan-source/debug/Alien-Base-ModuleBuild-1.14/blib/arch
#
#
#
# perl                    5.032000
# Acme::Alien::DontPanic  -
# Alien::Base             2.26
# Alien::Base::PkgConfig  2.26
# Archive::Extract        0.86
# Archive::Tar            2.36
# Capture::Tiny           0.48
# Digest::SHA             6.02
# File::chdir             0.1010
# HTML::LinkExtor         3.69
# HTTP::Tiny              0.076
# Inline                  -
# Inline::C               -
# Inline::CPP             -
# LWP::UserAgent          6.46
# List::Util              1.55
# Module::Build           0.4231
# Path::Tiny              0.114
# Shell::Config::Generate 0.34
# Shell::Guess            0.09
# Sort::Versions          1.62
# Test2::V0               0.000130
# Text::ParseWords        3.30
# URI                     1.76
# URI::file               4.21
# parent                  0.238
#
#
#
t/00_diag.t .................................. ok
t/alien_base_modulebuild.t ................... ok
t/alien_base_modulebuild_cabinet.t ........... ok
t/alien_base_modulebuild_file.t .............. ok
t/alien_base_modulebuild_repository.t ........ ok
t/alien_base_modulebuild_repository_ftp.t .... ok
t/alien_base_modulebuild_repository_http.t ... 1/?         # Failed test at t/alien_base_modulebuild_repository_http.t line 102.
        # +------+------------------+---------------------+
        # | PATH | GOT              | CHECK               |
        # +------+------------------+---------------------+
        # | [0]  | <DOES NOT EXIST> | relativepackage.txt |
        # +------+------------------+---------------------+
    # Failed test 'LWP::UserAgent'
    # at t/alien_base_modulebuild_repository_http.t line 103.

# Failed test 'list_files()'
# at t/alien_base_modulebuild_repository_http.t line 104.
t/alien_base_modulebuild_repository_http.t ... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/9 subtests
t/alien_base_modulebuild_repository_local.t .. ok
t/alien_base_modulebuild_utils.t ............. ok
t/inline.t ................................... skipped: test requires Inline 0.56 + Inline::C + Acme::Alien::DontPanic 0.010
t/inline_cpp.t ............................... skipped: test requires Inline 0.56 + Inline::C + Acme::Alien::DontPanic 0.010

Test Summary Report
-------------------
t/alien_base_modulebuild_repository_http.t (Wstat: 256 Tests: 9 Failed: 1)
  Failed test:  4
  Non-zero exit status: 1
Files=11, Tests=58, 17 wallclock secs ( 0.06 usr  0.09 sys +  3.91 cusr  7.70 csys = 11.77 CPU)
Result: FAIL
Failed 1/11 test programs. 1/58 subtests failed.
@hakonhagland
Copy link
Author

I believe this failure comes from line 157 in Alien::Base::ModuleBuild::Repository::HTTP

return ( 0, $res->decoded_content, \%headers, $res->request->uri );

The call to $res->decoded_content calls decoded_content() in HTTP::Message line 281, which calls content_charset() at line 205, which calls require IO::HTML at line 247 which throws since IO::HTML is not installed. The exeception is caught at line 406 which causes decoded_content() to return an undef value.

I have raised an issue at MSYS2-packages if IO::HTML should be installed as a dependency when HTTP::Message comes installed with the distribution.

@plicease
Copy link
Member

Looks like this was fixed in MSYS2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants