Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Add explicit hostnames to the README. 2. Fix some typos #166

Closed

Conversation

shlomif
Copy link
Contributor

@shlomif shlomif commented Aug 23, 2015

Hi! Sorry for the stray commit in the previous pull-req. Here is a better one with only the relevant (and hopefully - non-controversial) changes.

Shlomi Fish added 2 commits August 23, 2015 11:00
This is for better search engine compliance and other stuff. I recall
the repository being very hard to find on search engines.
"Many" instead of "May" and missing "although".
@shlomif
Copy link
Contributor Author

shlomif commented Sep 5, 2015

Hi all,

did you look into this pull request? Do you find the proposed changes acceptable and noncontroversial? In the last pull-request, I had to wait for many months before it was rejected, which wasn't a pleasant experience. Please look into merging this pull-req.

Regards,

-- @shlomif

@ranguard
Copy link
Member

ranguard commented Sep 5, 2015

I will review in the next couple of days.. Have been at YAPC::EU

On 5 Sep 2015, at 16:24, Shlomi Fish notifications@github.com wrote:

Hi all,

did you look into this pull request? Do you find the proposed changes acceptable and noncontroversial? In the last pull-request, I had to wait for many months before it was rejected, which wasn't a pleasant experience. Please look into merging this pull-req.

Regards,

-- @shlomif


Reply to this email directly or view it on GitHub.

@shlomif
Copy link
Contributor Author

shlomif commented Sep 5, 2015

On Sat, 05 Sep 2015 10:22:16 -0700
Leo Lapworth notifications@github.com wrote:

I will review in the next couple of days.. Have been at YAPC::EU

Thanks, Leo! I hope you had a good time there.

Regards,

-- Shlomi Fish


Shlomi Fish http://www.shlomifish.org/
Rethinking CPAN - http://shlom.in/rethinking-cpan

We agree. But do we agree to agree?

Please reply to list if it's a mailing list post - http://shlom.in/reply .

@@ -8,8 +8,8 @@
</h2>

<p>
There are many <a href="/books/">Perl books</a>, you many also find these
links useful.
Although there are many <a href="/books/">Perl books</a>, you may also find
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although/may does not help clarify the intent here.

@rspier
Copy link
Contributor

rspier commented Sep 5, 2015

Thank you for sending a pull request. See inline comments as to why it is not going to be applied.

@rspier rspier closed this Sep 5, 2015
@perlorg perlorg locked and limited conversation to collaborators Sep 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants