Replace CPAN ratings site with redirects to metacpan #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rspier I restarted the containers in kube and because the git:// change the old one doesn't sync anymore (oops), so it's running off this branch now. When merged I'll switch the site back to run off main. |
rspier
reviewed
Feb 3, 2022
lib/CPANRatings/Model/SearchCPAN.pm
Outdated
| } | ||
| else { | ||
| $data = []; | ||
| my $url = "http://search.cpan.org/search?query=$query&mode=$mode&format=xml"; |
There was a problem hiding this comment.
Does this API actually still work?
There was a problem hiding this comment.
I thought it did because the site worked, but it's failing in a way that I will just leave it out instead.
rspier
reviewed
Feb 3, 2022
lib/CPANRatings/Model/SearchCPAN.pm
Outdated
| } | ||
|
|
||
| sub _search { | ||
| my ($self, $mode, $query) = @_; | ||
| my ($self, $mode, $query) = @_; |
There was a problem hiding this comment.
Looks like this introduced some unnecessary whitespace changes.
There was a problem hiding this comment.
yeah, it was whatever my editor did. I tried doing perl tidy on the files but that just made different changes... 🤷
rspier
approved these changes
Feb 3, 2022
…g, so don't bother
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.