Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposed changes to use more of Moo #15

Closed
wants to merge 15 commits into from
Closed

proposed changes to use more of Moo #15

wants to merge 15 commits into from

Commits on Dec 30, 2016

  1. some type constraints

    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    6a5f587 View commit details
    Browse the repository at this point in the history

  2. more correct complex types

    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    9956fbf View commit details
    Browse the repository at this point in the history

  3. ::Run::Output can be anything, not just a string

    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    4075d3b View commit details
    Browse the repository at this point in the history

  4. type constraints for ::Run::Response 

    I'm assuming that the `->callbacks([])` in the test was a mistype
    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    909d957 View commit details
    Browse the repository at this point in the history

  5. types for ::Role::Command 

    Interesting detail: if the main spec does not declare subcommands, the
various plugins' ->install_subcommands will be invoked, but will not
have any effect

I suspect this is a bug.
    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    f0630a5 View commit details
    Browse the repository at this point in the history

  6. rename types for better clarity

    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    fc0413e View commit details
    Browse the repository at this point in the history

  7. type constraint in ::Pod

    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    59e22db View commit details
    Browse the repository at this point in the history

  8. type constraints in ::Run::Validator

    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    f015a29 View commit details
    Browse the repository at this point in the history

  9. type constraints for ::Spec

    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    29b0dba View commit details
    Browse the repository at this point in the history

  10. CommandOp type 

    an op can be either a method name, or a coderef to be invoked as a
method
    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    3a26411 View commit details
    Browse the repository at this point in the history

  11. types for ::Run

    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    bf50b4e View commit details
    Browse the repository at this point in the history

  12. use BUILDARGS/new instead of common/build

    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    ec819f4 View commit details
    Browse the repository at this point in the history

  13. simpler ::Argument buildargs

    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    056d17c View commit details
    Browse the repository at this point in the history

  14. simpler plugin handling in ::Command

    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    7bd67ed View commit details
    Browse the repository at this point in the history

  15. tweaks from external tests

    @dakkar
    dakkar committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    6d10ca1 View commit details
    Browse the repository at this point in the history