-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboards as CRDs #8
Conversation
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
03f6103
to
75f56df
Compare
Requires perses/perses#1764 so the CRD generation validates the correct types |
addresses #4 |
db6a89b
to
5abe4a8
Compare
@@ -0,0 +1,20 @@ | |||
package v1alpha1 | |||
|
|||
import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very important!
But since we're a scoped on the perses operator IMO we can avoid names like perses_dashboard
we can call only dashboards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to keep the perses prefix as this will be in line with the CRD name and can avoid name collisions for example when defining rbac rules.
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
5abe4a8
to
468f8d6
Compare
@nicolastakashi @Nexucis let me know if there are other things pending you'd like to review, otherwise I'd like to proceed to unblock #9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be good once Perses version is bumped to v0.44.0
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
bb92da1
to
2f6f998
Compare
This PR: