Dashboards as CRDs #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
jgbernalp
force-pushed
the
dashboards-as-crds
branch
from
03f6103
to
75f56df
Compare
|
Requires perses/perses#1764 so the CRD generation validates the correct types |
|
addresses #4 |
jgbernalp
force-pushed
the
dashboards-as-crds
branch
from
db6a89b
to
5abe4a8
Compare
Merged
| @@ -0,0 +1,20 @@ | |||
| package v1alpha1 | |||
|
|
|||
| import ( | |||
There was a problem hiding this comment.
Not very important!
But since we're a scoped on the perses operator IMO we can avoid names like perses_dashboard we can call only dashboards.
There was a problem hiding this comment.
I would prefer to keep the perses prefix as this will be in line with the CRD name and can avoid name collisions for example when defining rbac rules.
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
jgbernalp
force-pushed
the
dashboards-as-crds
branch
from
5abe4a8
to
468f8d6
Compare
|
@nicolastakashi @Nexucis let me know if there are other things pending you'd like to review, otherwise I'd like to proceed to unblock #9 |
nicolastakashi
approved these changes
Mar 26, 2024
Nexucis
approved these changes
Mar 26, 2024
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
jgbernalp
force-pushed
the
dashboards-as-crds
branch
from
bb92da1
to
2f6f998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: