[ENHANCEMENT] add kubebuilder annotations to dashboard types #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nexucis
reviewed
Feb 16, 2024
| Extension FileExtension `json:"extension" yaml:"extension"` | ||
| CaseSensitive bool `json:"case_sensitive" yaml:"case_sensitive"` | ||
| Folder string `json:"folder" yaml:"folder"` | ||
| Extension FileExtension `json:"extension" yaml:"extension"` |
There was a problem hiding this comment.
Extension is also optional if you want to annotate it
|
regarding the issue with the doc, I have tackled in a different PR: #1765 |
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
jgbernalp
force-pushed
the
add-kubebuilder-annotations-for-dashboards-crds
branch
from
a205028
to
5ef9950
Compare
Nexucis
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds kubebuilder annotations to dashboard related types, this allows that the Dashboard CRD for Perses is generated correctly
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
no UI Changes