Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] CLI: add config to tune the DaC output folder + internal improvements for CLI testing #1753

Merged
merged 4 commits into from
Feb 13, 2024
Merged

[ENHANCEMENT] CLI: add config to tune the DaC output folder + internal improvements for CLI testing #1753

merged 4 commits into from
Feb 13, 2024

Conversation

AntoineThebaud
Copy link
Contributor

@AntoineThebaud AntoineThebaud commented Feb 11, 2024 •
edited

Description

  • Added new config to tune the DaC output folder:
    • it's wraped in a Dac struct in anticipation of other dac-specific configs to come
    • "built" is still the value by default
  • CLI test framework modified to allow customizing any part of the config
  • Fixed some broken unit tests on windows

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

@AntoineThebaud AntoineThebaud force-pushed the antoinethebaud/dac-custom-output-folder branch 3 times, most recently from e8ebe4d to 61b9f66 Compare February 11, 2024 18:10
@AntoineThebaud AntoineThebaud marked this pull request as ready for review February 11, 2024 18:24
@AntoineThebaud AntoineThebaud mentioned this pull request Feb 11, 2024
Merged
3 tasks
Gladorme
Gladorme approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@Gladorme Gladorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😄

@AntoineThebaud
[ENHANCEMENT] CLI: add config to tune the DaC output folder + interna…
01629c6 
…l improvements for CLI testing

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
bring back APIClient as a private member
b07c167 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud
Remove getter for output dir
7e23bb8 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud force-pushed the antoinethebaud/dac-custom-output-folder branch from 1ae0d7b to 7e23bb8 Compare February 12, 2024 14:46
@AntoineThebaud
reorder attributes
24feb31 
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud merged commit 70f28ea into feat/dashboard-as-code Feb 13, 2024
19 checks passed
@AntoineThebaud AntoineThebaud deleted the antoinethebaud/dac-custom-output-folder branch February 13, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis Nexucis approved these changes

@Gladorme Gladorme Gladorme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AntoineThebaud @Nexucis @Gladorme