-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : test file fixes 1 #223
Merged
deepanshutr
merged 21 commits into
persistenceOne:master
from
bahdotsh:bahdev/testfilefixes
May 3, 2021
Merged
WIP : test file fixes 1 #223
deepanshutr
merged 21 commits into
persistenceOne:master
from
bahdotsh:bahdev/testfilefixes
May 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepanshutr
approved these changes
May 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed.
puneet2019
pushed a commit
that referenced
this pull request
Jul 30, 2022
* Add more grpc queries for the pool incentives module * Add `IncentivizedPools` grpc query * Update the swagger docs * Minor fix * Fix missed registering codec for the internal lockup module amino codec * Add grpc http gateway for the lockup module & update the swagger docs * Add missing ABCI handler for `epochs` module * Fix typo * ran make docs Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch>
Anmol1696
added a commit
that referenced
this pull request
Aug 22, 2022
* General epochs (#108) * write spec, init with starpot * remove queries * Update x/epochs/spec/README.md Co-authored-by: Sunny Aggarwal <sunny@sikka.tech> * Update x/epochs/spec/README.md Co-authored-by: Sunny Aggarwal <sunny@sikka.tech> * add description for inclusive of block for epoch end * time basis epoch implementation - progress * remove scaffolding comments * updates * implementation for epochs module detail cases * add tests for epochs * Update x/epochs/abci.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * integrate general epochs into incentives (#119) * resolve conflicts * Update x/epochs/spec/README.md Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Update x/epochs/spec/README.md Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * changes for comments * add test for import / export genesis * implement table based test * add chainStartTime to tests Co-authored-by: Sunny Aggarwal <sunny@sikka.tech> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * General epochs remaining fixes (#158) * add test for incentives genesis export / import, remove epochs empty file * fix epoch start code and add test for epoch start * modify tests * Update x/epochs/abci.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Sunny Aggarwal <sunny@sikka.tech> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Add `TotalPools()` query * Register the GRPC gateway for the epochs module * c-osmosis -> osmosis-labs (#153) * json marshal to proto marshal (#193) * Epoch/lockup module bug fix and grpc chores (#223) * Add more grpc queries for the pool incentives module * Add `IncentivizedPools` grpc query * Update the swagger docs * Minor fix * Fix missed registering codec for the internal lockup module amino codec * Add grpc http gateway for the lockup module & update the swagger docs * Add missing ABCI handler for `epochs` module * Fix typo * ran make docs Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch> * Prepare Testnet Genesis (#243) * choose mainnet or testnet for prepare genesis * rename epochs to day and week * in progres * fix simapp -> app * Missing API Endpoints (#258) * add current epoch query * add cli for query num pools * Continuing work on getting the simulator to run with our custom ops (#245) * Register gamm operations on simulator * Get sim_test working until initchain * Register epochs module on simulator * Epochs have simulation logic, more changes to simapp sim_test * Update go.mod/sum * Simulator working * Turn commit off * Turn simulator commit back on due to mysterious error * Bump SDK version to fix simulation min commission rate * Update to version cosmos-sdk that fixes mega-slowness in existing simulation operation * cli command and test for missing endpoints at epochs/epochsinfo (#259) * Incentives missing endpoints (#260) * incentives missing endpoints * add tests for incentives cli commands * Fix some lints (#275) * Removed duplicate code from Epochs module BeginBlocker (#305) * Add spec for claim/mint/lockup/incentives/epochs module (#331) * add docs for incentives module * more content on docs * add spec for lockup module and enhancement of incentives module spec * modify mint module spec * add spec for epochs * claim sepc * Improve claims spec * Un-delete lockup keeper docs Co-authored-by: ValarDragon <dojha12@gmail.com> * Add validation for unique epoch identifier (#396) * Add validation for unique epoch identifier * Add test code for unique epoch identifier * Make validateEpochIdentifier a function defined by x/epochs (#398) * Add epoch identifier functions * Replace validateEpochIdentifier functions * Add genesis test code for mint module * Replace duplicate function in incentives module * Add test code for genesis validation * Fix Epoch Time Drift (#403) * Modify abci logic: time drift disabled * Move CurrentEpochStartTime initialization to abci.go * Modify test codes for epoch module * Modify initializing startTime, currentEpochStartTime logic * Fix test cases * Execute AfterEpochEnd, BeforeEpochStart consecutively * Change in comment * Add logging when new epoch starts * Move all logic from Endblock to BeginBlock * reserve proto field for current_epoch_ended(deprecated) * Reserve proto, update logic for begin blocker of epoch time drift * Clearify test code for abci * chore: bump gogo/protobuf (#498) * chore: bump gogo/protobuf * regenerate proto files * bump other dependencies * rollback tendermint and iavl updates * Fix lint - errcheck (#491) * Fix lint - errcheck * Minor fixes: test cases, panic added * Add nolint:errcheck to module.go * Add Block Height to EpochInfo (#562) * feat(epochs): track block height in epoch info * refactor(epochs): use single field to track epoch block height * refactor(abci test): test legacy EpochInfo message compatability * Cosmos SDK 0.44.* series upgrade for Osmosis (#538) Co-authored-by: ValarDragon <dojha12@gmail.com> * Make all keepers pointers, use multiple initialization methods (#697) * Make all keepers pointers, use multiple initialization methods * Split out new store loader logic * Make antehandler input simpler * Improve comment * Improve comment * epoch num added to log * Superfluid basic simulation, tx/query CLI commands, resolve single node test issues (#784) * add basic changes for simulation * add superfluid message types * register msg server, handler, fix build issues, configure basic actions for superfluid operations * resolve message validatebasic, fix automatic delegation from intermediary account, increase simulation coverage * Put superfluid unbonding duration as param, simulation test genesis manipulation * add simulation for proposals * add basic checker for superfluid operations * update reward management logic * add tx commands for superfluid delegate * add cli commands for proposals * single node configuration as epoch - min and relevant times * resolve twap price issue, synthetic lockup distribution, connect epochs hook to superfluid, fix gauge creation issue * fix simulation weights * superfluid lockup ownership check & error handling & queries & addTokensToLock/removeTokensFromLock connection with synthetic lockup * add more test plans * further test steps * Add SuperfluidDelegateMore feature, Add common codebase for GetSuperfluidOSMOTokens from twap * simplify epoch management & resolve unit tests * add missing queries and unit tests * resolve accumulation store management issue for synthetic lockup * PR cleanup * remove reward distribution delay, fix superfluid asset removal price * Fix gas tests Co-authored-by: ValarDragon <dojha12@gmail.com> * min duration from days to hours, changed weekly to day (#859) * min duration from 1d to 24h (d not recognized), changed weekly to day (weekly doesnt work, only week) * changed from seconds to hours * Semantic versioning for v7 (#804) * update go.mod * fix order adding in app.go * update hardcoded gas amounts * Annotate app.go * Delete .gitpod.yml * go fmt * finish annotation * Update CHANGELOG.md * Update app/app.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * v7 * Semantic versioning * remove artifact that make-proto didn't catch * clean * go mod tidy * ensure all imports refer to v7 * fmt Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Add NumBlocksSinceEpochStart function (#909) * call EpochEnd event before increasing (#1043) * Add some more code comments for functions discussed with @alexanderbez (#1126) * Add some more code comments for functions discussed with @alexanderbez * Try to simplify the BeginEpoch logic * A much smaller set of newly enabled linters (#1127) * A much smaller set of newly enabled linters * Apply suggestions from code review Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update Make lint, disable gofumpt and godot until future * changelog Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: ValarDragon <dojha12@gmail.com> * refactor: move gRPC methods to dedicated type (#1169) * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * fix tests * chore: add nil checks and tweaks to gRPC handlers (#1238) * Enable gofumpt (#1179) * Update Makefile Draft PR aimed at enabling fumpt linter and using golangci-lint run --fix to make developer environments match ci * update to go1.18 * Update Makefile * fumpt & update makefile to exclude dirs * Update Makefile Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update Makefile Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update Makefile Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * refactor: Test suites refactor #1297 * Epoch hooks, panic recovery (#1308) Add panic recovery to hook logic, improve error logging for panics Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Roman <34196718+p0mvn@users.noreply.github.com> * Remove gofumpt from required lints, directly use it in make format (#1318) ## What is the purpose of the change Closes: #1309 , context is in the issue. TL;DR, remove gofumpt from being required in CI due to barriers to entry / lack of ease of use with default IDE setups. Its kept in make format, and make format is intended to be ran pre-releases ## Brief change log Remove gofumpt from being required. ## Testing and Verifying This change is a trivial rework / code cleanup without any test coverage. ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? yes - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? No -- This is not done, as gofumpt was also added in unreleased code, so this is no net change - How is the feature or change documented? N/A * Delete unused REST endpoints from modules (#1396) ## What is the purpose of the change Deletes unused REST packages, as they are deprecated. There is still rest code in `x/mint`, `x/lockup`, and for the various governance proposals. Those should probably be deleted later, as REST is fully deleted in main SDK in v0.46 (but no integrators have had a chance to adapt yet) ## Brief change log - Delete unused REST endpoints, should be no user-facing change, as nothing was being done for the modules its deleted from ## Testing and Verifying *(Please pick one of the following options)* This change is a trivial rework / code cleanup without any test coverage. ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? no - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no - How is the feature or change documented? Not applicable * chore: Delete unused RegisterCodec functions, and store key param for cli queries (#1400) ## What is the purpose of the change Deletes unused `RegisterCodec` function, and store key param for CLI queries. I was just going through the module.go APIs, and saw these in our module.go's. ## Testing and Verifying This change is a trivial rework / code cleanup without any test coverage. All imports changes were done by automated tooling, I didn't manually change any of them. ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? no - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no - How is the feature or change documented? not applicable * chore: enable markdown linter (#1478) * Docbuild automation (#1492) * docbuild automation * tokenmodule spec docs * sidebar fixes * formatting fixes * superlinter fixes * superlinter fixes * superlinter fixes * superlinter fixes * superlinter fixes * superlinter fixes * superlinter fixes Co-authored-by: Xiangan He <xiangan@polychain.capital> * Docs fixes (#1566) * docbuild automation * tokenmodule spec docs * sidebar fixes * formatting fixes * superlinter fixes * superlinter fixes * superlinter fixes * superlinter fixes * superlinter fixes * superlinter fixes * superlinter fixes * docs fixes * docs fixes * docs fixes * docs fixes * docs fixes * markdown lint fixes + disabled M024 * markdown lint fixes + disabled M024 * markdown lint fixes + disabled M024 * markdown lint fixes + disabled M024 * markdown lint fixes + disabled M024 * markdownlint yaml fixes * markdownlint yaml fixes * markdownlint yaml fixes Co-authored-by: Xiangan He <xiangan@polychain.capital> Co-authored-by: Daniel Farina <contact@nevulas.com> * Small test e2e updates / boilerplate notes (#1625) * Upgrade v9.x branch to v9 import path (#1633) * Epochs module documentation (backport #1821) (#1867) * Epochs module documentation (#1821) * Some initial work on epochs module docs * More proto docs * Simplify conditional logic from review * Update epochs docs * Fix docs * Delete obsoleted edge case discussion. (Edge case details were moved to top level desc.) * Remove protobuf overhead * Apply discussed x/epochs changes * Address genesis proto feedback (cherry picked from commit 09975ee) # Conflicts: # go.mod # x/gamm/pool-models/balancer/tx.pb.go * Fix conflict, revert "technical" state break edge case * Run make proto-all Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu> * Update import paths from v9 to v10 on v10.x (#2000) * Update import paths from v9 to v10 on v10.x * Update import paths from v9 to v10 on v10.x * Making CI for testing generated proto correctness (backport #1892) (#2074) * Making CI for testing generated proto correctness (#1892) (cherry picked from commit 0956d89) # Conflicts: # chain.schema.json * Fix proto Co-authored-by: Xiangan He <76530366+xBalbinus@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu> * chore: move init export genesis to keepers (backport #1631) (#2139) * chore: move init export genesis to keepers (#1631) * move init export genesis to keepers * add back genesis_test for gamm Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> (cherry picked from commit 61a207f) # Conflicts: # app/upgrades/v5/upgrades.go # x/epochs/abci_test.go # x/epochs/keeper/genesis.go # x/epochs/keeper/genesis_test.go # x/gamm/keeper/genesis.go # x/incentives/keeper/genesis.go # x/incentives/keeper/genesis_test.go # x/lockup/keeper/genesis.go # x/lockup/keeper/genesis_test.go # x/mint/keeper/genesis.go # x/mint/keeper/genesis_test.go # x/pool-incentives/keeper/geneis_test.go # x/pool-incentives/keeper/genesis.go # x/superfluid/keeper/genesis.go # x/superfluid/keeper/genesis_test.go # x/txfees/keeper/genesis.go * fix imports and run linter Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: alpo <yukseloglua@berkeley.edu> * Delete unused simulator code (backport #1671) (#2158) * Delete unused simulator code (#1671) * Delete unused simulator code * Add hourly epochs to the x/epochs DefaultGenesis * Add changelog * Delete the unused x/gamm/simulation folder * Fix epochs module tests for updated DefaultGenesis (cherry picked from commit f21e29e) # Conflicts: # CHANGELOG.md # x/epochs/module.go # x/epochs/simulation/genesis.go # x/gamm/module.go # x/gamm/simulation/operations.go # x/mint/simulation/params_test.go * fix conflicts and align backport with actual PR * fix changelog conflict Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: alpo <yukseloglua@berkeley.edu> Co-authored-by: alpo <62043214+AlpinYukseloglu@users.noreply.github.com> * added epochs module using subtree * removed coverage action to run when pushed to master * removed epochs * addd * fixed imports and tests * fixed code covergae report * utils refactored * removed .DS_STORE * Update proto/epochs/v1beta1/query.proto Co-authored-by: antstalepresh <36045227+antstalepresh@users.noreply.github.com> Co-authored-by: Sunny Aggarwal <sunny@sikka.tech> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Thunnini <yunjh1994@gmail.com> Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch> Co-authored-by: Srinivas Baride <b.srinivas8687@gmail.com> Co-authored-by: ValarDragon <dojha12@gmail.com> Co-authored-by: Changhyun, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: Greg Morrison <freedomtoroam@posteo.de> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: Adam Tucker <adamleetucker@outlook.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: khanh <50263489+catShaark@users.noreply.github.com> Co-authored-by: Roman <34196718+p0mvn@users.noreply.github.com> Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: Xiangan He <76530366+xBalbinus@users.noreply.github.com> Co-authored-by: Xiangan He <xiangan@polychain.capital> Co-authored-by: Daniel Farina <contact@nevulas.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu> Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: alpo <yukseloglua@berkeley.edu> Co-authored-by: alpo <62043214+AlpinYukseloglu@users.noreply.github.com> Co-authored-by: Anmol <anmol1696@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.