Added Jaco and mico meshes and urdfs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: ada_srdf.xacro
modified: ada_srdf.xacro
modified: ada_urdf.xacro modified: kinova_common.xacro
modified: ada.urdf modified: ada_urdf.xacro modified: kinova_common.xacro
modified: ada.srdf modified: ada_srdf.xacro
deleted: README.txt modified: ada.urdf
gilwoolee
suggested changes
Apr 21, 2018
|
|
||
| find_package(catkin REQUIRED COMPONENTS | ||
| urdf | ||
| transmission_interface |
There was a problem hiding this comment.
If you look at ada.urdf.. it uses transmission to define the relationship between the actuators and the arm joints (defined as Simple Transmission type) ..
package.xml
Outdated
| <package> | ||
| <name>ada_description</name> | ||
| <version>2.0.0</version> | ||
| <description>Models for UW-ADA components</description> |
package.xml
Outdated
|
|
||
| <license>TODO</license> | ||
|
|
||
| <author email="xyz@uw.edu">XYZ</author> |
There was a problem hiding this comment.
You should put your name here. :)
[WIP] Set joint limits
new file: meshes/forque_kinova.dae modified: robots/ada_accessories.urdf
…cs/ada_description into robot_accessories
Robot accessories
jslee02
reviewed
May 5, 2018
|
@gilwoolee It seems most of the feedback is addressed. Can we merge this as it is and then fix further issues later? This is blocking setting up Travis CI of repos that depend on this repo. |
This was referenced May 6, 2018
Merged
gilwoolee
approved these changes
May 6, 2018
| <scene> | ||
| <instance_visual_scene url="#VisualSceneNode"/> | ||
| </scene> | ||
| </COLLADA> |
|
|
||
| <maintainer email="tapo@uw.edu">Tapomayukh Bhattacharjee</maintainer> | ||
|
|
||
| <license>TODO</license> |
There was a problem hiding this comment.
Let's use BSD as other repos we have.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial PR is to add meshes and urdfs and srdfs to load the ADA model in rviz and support libada..