Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose custom velocityLimits in ConcreteRobot retimers #558

Closed
egordon opened this issue Nov 14, 2019 · 2 comments
Closed

Expose custom velocityLimits in ConcreteRobot retimers #558

egordon opened this issue Nov 14, 2019 · 2 comments
Assignees

Comments

@egordon
Copy link
Contributor

egordon commented Nov 14, 2019

Currently, all retiming functions just pull the velocity limits directly from the MetaSkeleton. To get around this, ADA currently sets the MetaSkeleton velocity limits manually, calls the retimer, and then resets them to the previous values.

Instead, this should be exposed as an optional argument (default is to use the MetaSkeleton), as there are times where we may want the robot to move more slowly for a specific trajectory.

See comments on libada PR40 for more details (personalrobotics/libada#40).

@brianhou
Copy link
Contributor

I wonder if this makes sense to add as another possible field in the parameter struct for post-processors, which @sniyaz started working on in https://github.com/personalrobotics/libherb/pull/114. (Those struct definitions should eventually move to aikido.)

@sniyaz sniyaz self-assigned this Jun 26, 2020
@sniyaz
Copy link

sniyaz commented Aug 7, 2020

Closed now that #579 is merged.

@sniyaz sniyaz closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants