Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in collision checking of VPF #303

Merged
merged 14 commits into from Feb 6, 2018

Conversation

dqyi11
Copy link
Contributor

@dqyi11 dqyi11 commented Jan 18, 2018

Fix the wrong way of calling StepSequence in collision checking of VPF.

  • Document new methods and classes (N/A)

  • Format code with make format

  • Set version target by selecting a milestone on the right side

  • Summarize this change in CHANGELOG.md

  • Add unit test(s) for this change (N/A)

@dqyi11 dqyi11 added the bug label Jan 18, 2018
@dqyi11 dqyi11 added this to the Aikido 0.3.0 milestone Jan 18, 2018
@dqyi11 dqyi11 requested a review from brianhou January 18, 2018 22:14
@dqyi11
Copy link
Contributor Author

dqyi11 commented Jan 19, 2018

Now the test will fail because of a bug in the iterator of StepSequence.
StepSequence seq2(0.2, false); for (double v : seq2) { DART_UNUSED(v); count++; }

An exception will be throw

unknown file: Failure
C++ exception with description "Indexed maximum intenger." thrown in the test body.```

I created another PR #305 to fix it.

Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VFP test is still failing. Is this expected?

CHANGELOG.md Outdated
@@ -29,7 +29,7 @@
* Planner

* Added World class: [#243](https://github.com/personalrobotics/aikido/pull/243), [#252](https://github.com/personalrobotics/aikido/pull/252), [#265](https://github.com/personalrobotics/aikido/pull/265)
* Added vector field planner [#246](https://github.com/personalrobotics/aikido/pull/246), [#262](https://github.com/personalrobotics/aikido/pull/262), [#268](https://github.com/personalrobotics/aikido/pull/268)
* Added vector field planner [#246](https://github.com/personalrobotics/aikido/pull/246), [#262](https://github.com/personalrobotics/aikido/pull/262), [#268](https://github.com/personalrobotics/aikido/pull/268), [#303](https://github.com/personalrobotics/aikido/pull/303)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to 0.3.0. 0.2.0 is released.

@dqyi11
Copy link
Contributor Author

dqyi11 commented Jan 20, 2018

It is still failing for the same reason.
The issue in StepSequence is not fully addressed.
I will fix that.

@brianhou brianhou mentioned this pull request Jan 25, 2018
@codecov
Copy link

codecov bot commented Feb 6, 2018

Codecov Report

Merging #303 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   81.01%   81.06%   +0.04%     
==========================================
  Files         204      204              
  Lines        6005     6005              
==========================================
+ Hits         4865     4868       +3     
+ Misses       1140     1137       -3
Impacted Files Coverage Δ
...rc/planner/vectorfield/BodyNodePoseVectorField.cpp 66.66% <ø> (ø) ⬆️
include/aikido/planner/vectorfield/VectorField.hpp 100% <ø> (ø) ⬆️
...do/planner/vectorfield/BodyNodePoseVectorField.hpp 100% <ø> (ø) ⬆️
src/planner/vectorfield/VectorFieldPlanner.cpp 75% <100%> (+5%) ⬆️
...anner/vectorfield/detail/VectorFieldIntegrator.cpp 95.08% <100%> (ø) ⬆️

@jslee02 jslee02 merged commit 98bf11d into master Feb 6, 2018
@jslee02 jslee02 deleted the bugfix/dqyi/fixStepSequenceInCollisionCheckingInVPF branch February 6, 2018 22:57
gilwoolee pushed a commit that referenced this pull request Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants