Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Barrett-Specific executors. #380

Merged
merged 5 commits into from Apr 22, 2018
Merged

Remove Barrett-Specific executors. #380

merged 5 commits into from Apr 22, 2018

Conversation

aditya-vk
Copy link
Contributor

@aditya-vk aditya-vk commented Apr 21, 2018 •
edited

Addresses #375
Moved to libherb in https://github.com/personalrobotics/libherb/pull/90

Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@aditya-vk aditya-vk added this to the Aikido 0.3.0 milestone Apr 21, 2018
@codecov
Copy link

codecov bot commented Apr 22, 2018 •
edited

Codecov Report

Merging #380 into master will increase coverage by 0.2%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #380     +/-   ##
=========================================
+ Coverage   80.92%   81.13%   +0.2%     
=========================================
  Files         206      200      -6     
  Lines        6040     5687    -353     
=========================================
- Hits         4888     4614    -274     
+ Misses       1152     1073     -79
Impacted Files Coverage Δ
include/aikido/control/PositionCommandExecutor.hpp 0% <0%> (-100%) ⬇️
src/planner/ompl/CRRT.cpp 75.58% <0%> (-0.59%) ⬇️

gilwoolee
gilwoolee previously approved these changes Apr 22, 2018
View reviewed changes
jslee02
jslee02 previously approved these changes Apr 22, 2018
View reviewed changes
@jslee02
Copy link
Member

jslee02 commented Apr 22, 2018

@aditya-vk Could you update the changelog accordingly? Other than that, it looks good to go. Thanks!

@aditya-vk aditya-vk dismissed stale reviews from jslee02 and gilwoolee via 677c3c6 April 22, 2018 19:55
@aditya-vk
Copy link
Contributor Author

aditya-vk commented Apr 22, 2018 •
edited

@jslee02 Done! Will merge once the tests pass and is approved.

@aditya-vk aditya-vk merged commit 22a6761 into master Apr 22, 2018
@aditya-vk aditya-vk deleted the removeBarrettExecutors branch April 22, 2018 23:37
@aditya-vk aditya-vk mentioned this pull request Apr 22, 2018
Closed
gilwoolee pushed a commit that referenced this pull request Jan 21, 2019
@aditya-vk
Remove Barrett-Specific executors. (#380)
4555e88 
* remove barrett specific files

* remove Barrett-specific executor tests

* update log

* nit correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jslee02 jslee02 jslee02 approved these changes

@gilwoolee gilwoolee gilwoolee left review comments

@brianhou brianhou Awaiting requested review from brianhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Aikido 0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aditya-vk @jslee02 @gilwoolee