-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async Matrix.toBuffer() #21
Comments
Yeah, this seems reasonable. |
Ok, do you want to try this out in the async-toBuffer branch? There's a new method called toBufferAsync(cb) on matrix. I know this is kinda ugly, and at some point I can conceive switching the default behaviour to be async, and have the sync method be called toBufferSync, to match the other node modules, but I don't want to break peoples code at this point. |
Why not do it node-canvas style and run sync if toBuffer receives no arguments and async if it receives a callback? |
Great idea, ok, gonna merge it into master now. |
Has this been published to npm? |
not yet - I have another branch I was hoping to get done before bumping the On 12 November 2012 12:03, Eric Schoffstall notifications@github.comwrote:
Peter Braden |
It's fine I can just put the git master url in my package.json - was JW |
I just bumped it anyway - should be at 0.0.9 |
I can grab 48233 camera frames per second but when I add a toBuffer() into the mix that number drops to 27. This is still fine for streaming video but if toBuffer was asynchronous it would probably be pretty high - is it possible to put the memcopy out into an async task using libuv?
The text was updated successfully, but these errors were encountered: