Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug on end of sstream crash due to "has not method end()" #65

Closed
wants to merge 1 commit into from
Closed

Conversation

matteocrippa
Copy link

I was experiencing an error using stream on missing method end, in this way we avoid that.

hope this helps.

@peterbraden
Copy link
Owner

Is this right? Should we be reading into a buffer on .write and only creating the matrix on .end?

@danschultzer
Copy link
Collaborator

@peterbraden I guess this is safe to close since it's more than 3 years old?

@peterbraden
Copy link
Owner

I think so. I don't think node streams require an end method, but if I'm wrong we can reopen for sure.

See https://nodejs.org/api/stream.html#stream_class_stream_writable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants