Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All navigation items are rendered inactive. #4

Open
gnetsys opened this issue Feb 18, 2014 · 25 comments
Open

All navigation items are rendered inactive. #4

gnetsys opened this issue Feb 18, 2014 · 25 comments

Comments

@gnetsys
Copy link

gnetsys commented Feb 18, 2014

When this item is installed all navigation items are rendered inactive.

@gnetsys
Copy link
Author

gnetsys commented Feb 18, 2014

https://www.dropbox.com/s/ri0qsbvisi8dl4b/Brackets-issue.mp4, here a link to a video on the issue.

@peterflynn
Copy link
Owner

Definitely doesn't happen for me, and never reported before. I see this came from adobe/brackets#6902... @gnetsys, I think in the original report you mentioned using a custom build of brackets-shell? Does the problem occur when you use a regular Brackets installed build from download.brackets.io?

It shouldn't be possible for anything in Brackets JS code to prevent the minimize/maximize buttons from working, so I'm guessing this is some sort of native problem.

@gnetsys
Copy link
Author

gnetsys commented Feb 18, 2014

I never use custom builds just the release builds. I am running Brackets
Sprint 36 now, the latest release, the plugin gave same issue.

@peterflynn
Copy link
Owner

So just to be clear...

  • If you have no extensions enabled, and you quit & relaunch Brackets, it works perfectly fine.
  • If you install only the SVG Preview extension, and you quit & relaunch Brackets, no part of the Brackets window (including the native chrome) responds to mouse clicks.

Is that correct?

Does this problem happen with Sprint 35? Or only with Sprint 36?

@gnetsys
Copy link
Author

gnetsys commented Feb 18, 2014

Yes thats correct..

@peterflynn
Copy link
Owner

What about the sprint 35 vs. 36 question?

Also, if you don't mind could you test in a Sprint 30 or earlier build as well? (That is, before the "dark shell" UI was added). You can download older builds by clicking the "All Downloads" link on the download site.

@gnetsys
Copy link
Author

gnetsys commented Feb 18, 2014

It happens with all version I have tested. From 32 up

@peterflynn
Copy link
Owner

Could you also test with a Sprint 30 or earlier build? It's important to know whether this is specific to the 'dark shell' window style or not.

Also, can you tell me your OS version & hardware?

Also... at what point does Brackets become unresponsive to mouse clicks? Is it immediately frozen like that as soon as it loads? Or do you have to actually view an SVG file first?

@gnetsys
Copy link
Author

gnetsys commented Feb 18, 2014

OS: Windows 7
8GB DDR3 / 2TB

It becomes unresponsive immediately on launch. Will test with sprint 30 and let you know by tomorrow.

@peterflynn
Copy link
Owner

@gnetsys Here's another thing you could check:

  1. Launch Brackets without SVG Preview installed/enabled
  2. Verify that clicking works properly
  3. Install SVG Preview via Extension Manager. Do not restart Brackets
  4. Does clicking still work at this point? Or does it stop responding the instant you install the extension?

Thanks for helping investigate.

@peterflynn
Copy link
Owner

Also, odd question but -- could you make sure your graphics drivers are up to date? (On the off chance that this is some sort of Chromium/CEF repaint related issue). I assume you have pretty recent graphics hardware?

@gnetsys
Copy link
Author

gnetsys commented Feb 19, 2014

Yep am running Radeon Sapphire with 1GB dedicated.

@gnetsys
Copy link
Author

gnetsys commented Feb 21, 2014

I installed a clean version of Brackets 26 and SVG preview and it worked well after install. However I left the application idle overnight and the it froze next mornig. I again could not use any navigation icons.

@peterflynn
Copy link
Owner

@gnetsys Did you open any SVG files during that time? Do you still see the freeze if you don't open or view any SVG files for the entire time Brackets is open?

@gnetsys
Copy link
Author

gnetsys commented Feb 21, 2014

No, I opened no SVG files during this time...

@peterflynn
Copy link
Owner

@gnetsys Can you try editing your copy of the extension to comment out the ExtensionUtils.loadStyleSheet() call at the bottom of main.js? That seems like the leading plausible explanation -- something in the CSS that is loaded immediately, even if you don't view any SVG files. Let me know if the problem still happens after commenting out that call.

@fr32c
Copy link

fr32c commented May 31, 2014

Hi Peter, as mentionned there : https://forums.adobe.com/message/6422625#6422625 i have the same thing with the extension. I tried your last advice with no success. As soon as the extension is in the user folder, Code becomes inactive.

@peterflynn
Copy link
Owner

@fr32c Sorry for slow reply. So if you comment out the ExtensionUtils block (https://github.com/peterflynn/svg-preview/blob/master/main.js#L297-L301) in my code, and then launch Brackets without opening any SVG files, you still see the problem? And it still happens immediately when Brackets is done loading, when you still haven't touched any SVG files yet?

@peterflynn
Copy link
Owner

If it really still happens then, can you try commenting out the entire module body? (Lines 30-301).

@fr32c
Copy link

fr32c commented Jun 23, 2014

Well, i didn't launch Code since :) I'm feeling good on Brackets, you know, and whenever someone asks, i send them there :)

@peterflynn
Copy link
Owner

@fr32c So you don't see this in Brackets? Only in Edge Code? That's weird...

The original report from @gnetsys was on Brackets though, so clearly whatever's going on affects a small number of installs of both versions...

@peterflynn
Copy link
Owner

@fr32c Anyway, if you ever have a few min to help out, please let me know. Would love to get some more info on what's going on here...

@gnetsys
Copy link
Author

gnetsys commented Jun 27, 2014

I removed svg preview. I have upgraded and installed the latest version. 0.41 will test again and give feed back...

@fr32c
Copy link

fr32c commented Jun 28, 2014

Yep, that's strange… Originally, that was a bracket's issue, that got somehow solved.

@peterflynn
Copy link
Owner

@gnetsys Thanks a ton for your help... very interested to hear what results you get!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants