-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming of multi? to quiet? can be breaking #865
Comments
Let me check on that. I thought I'd aliased all the public methods |
@larouxn So |
@petergoldstein, the calls are indeed directly on
If it's a public gem making the |
👋 Alright, I was able to find the |
@larouxn Ok, the |
It's used in an instrumentation library that I'm looking at for the first time right now. Seems to be used to ensure we don't instrument Dalli call latency during multi calls such as Hoping to tag someone with more context into here. |
Hey @petergoldstein we're doing something similar for dalli auto instrumentation in the opentelemetry-ruby repo. Ideally we (Otel ruby folks) would love to push for first party instrumentation in the dalli gem itself (let me know if you're open to this idea, I would be happy to contribute PRs towards this). However I don't want to try and pull this issue onto a tangent, would you be open to supplying a public method for performing this check so we could stop doing unsavoury things like relying on a private method? |
@robertlaurin So addressing this in order:
One note about all of this is that the quiet/multi block is not the only place where we use quiet memcached commands (which is a little confusing). Pipelined gets use quiet memcached commands without setting the thread context variable used by |
@robertlaurin and @larouxn Take a look at this - #866 . Let me know if that simplifies things for you. I'm ok packaging this and releasing as a 3.1.2 today. |
Will do!
That is very helpful, thank you!
I'll have to take a closer look at various places I know this being used to see what impact it could have on the accuracy on our instrumentation. Appreciate you flagging that. |
@robertlaurin @larouxn I've merged #866 and released 3.1.2 with that included. Hopefully that addresses the issue here. Please let me know if it doesn't. |
👋 Just a heads up issue that the recent 3.1.1 patch version release contained a rename of
multi?
toquiet?
which was a breaking change (no method error) for a service I was running. Not sure if that will be the case for many apps/services but just wanted to give a heads up. Maybe we can add a note to theHistory.md
warning people of potential breakage.The text was updated successfully, but these errors were encountered: