Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Constructor Options #94

Closed
4 tasks
peterstace opened this issue Jan 9, 2020 · 0 comments
Closed
4 tasks

Simplify Constructor Options #94

peterstace opened this issue Jan 9, 2020 · 0 comments
Assignees
Labels
good first issue Good for newcomers improve Improve (or remove) an existing feature

Comments

@peterstace
Copy link
Owner

peterstace commented Jan 9, 2020

There are currently 2 constructor options:

  • Disable All Validations
  • Disable Expensive Validations

The logic for working out which validations to perform can get a bit tricky... And the semantics around what an "expensive" validation also feels fuzzy.


Steps to implement this ticket:

  • Remove the DisableExpensiveValidations constructor option.
  • Remove the skipExpensiveValidations field of the ctorOptionSet type.
  • Remove the doExpensiveValidations and doCheapValidations methods on the ctorOptionSet type.
  • For each concrete geometry, skip all validation steps by checking the skipAllValidations flag on the ctorOptionSet struct (maybe rename the flag to skipValidations).
@peterstace peterstace added the improve Improve (or remove) an existing feature label Jan 9, 2020
@peterstace peterstace added the good first issue Good for newcomers label Feb 27, 2020
@peterstace peterstace self-assigned this Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improve Improve (or remove) an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant