Create animals table #1
Conversation
PeteUgwu
commented
Mar 2, 2023
•
PeteUgwu
commented
- Created a database named vet_clinic.
- Created a table named animals with given data
- Inserted given data
- Took screenshots of the queries results
There was a problem hiding this comment.
Hi @PeteUgwu,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
-
Correct GitHub Flow 👍
-
Good commit history 💰
-
Good PR title/description 💯
-
All linters passed 🏅
-
Personalised README file 👍
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
queries.sql
Outdated
| @@ -1,3 +1,10 @@ | |||
| /*Queries that provide answers to the questions from all projects.*/ | |||
|
|
|||
| SELECT * from animals WHERE name = 'Luna'; | |||
| SELECT * From animals WHERE name LIKE '%mon%'; | |||
| SELECT * From animals WHERE date_of_birth BETWEEN DATE '2016-01-01' AND DATE '2019-12-31'; | |||
There was a problem hiding this comment.
There is a specificity on what you are to select, that is "name". Instead of selecting *, kindly select the name 🥺 .
There was a problem hiding this comment.
Thanks, updated @Lizdev-05
queries.sql
Outdated
| SELECT * from animals WHERE name = 'Luna'; | ||
| SELECT * From animals WHERE name LIKE '%mon%'; | ||
| SELECT * From animals WHERE date_of_birth BETWEEN DATE '2016-01-01' AND DATE '2019-12-31'; | ||
| SELECT * From animals WHERE neutered = 'YES' AND escape_attempts < 3; |
There was a problem hiding this comment.
There is a specificity on what you are to select, that is "name". Instead of selecting *, kindly select the name 🥺 .
There was a problem hiding this comment.
Thanks, updated @Lizdev-05
queries.sql
Outdated
| SELECT * From animals WHERE date_of_birth BETWEEN DATE '2016-01-01' AND DATE '2019-12-31'; | ||
| SELECT * From animals WHERE neutered = 'YES' AND escape_attempts < 3; | ||
| SELECT date_of_birth from animals WHERE name IN ('Agumon','Pikachu'); | ||
| SELECT name, date_of_birth FROM animals WHERE weight_kg > 10.5; |
There was a problem hiding this comment.
You are to list name and escape attempts of animals that weigh more than 10.5kg not the date of birth. Kindly implement the changes. 🥺
There was a problem hiding this comment.
Thanks, updated @Lizdev-05
There was a problem hiding this comment.
Status: Approved 🟢 🥇 💯
Hey @PeteUgwu 👋
Great work on implementing the requested changes. Your project is complete. 😊
There is nothing else to say about your project. 👍
Highlights 🥇
✔️ Descriptive PR Title
✔️ Descriptive PR Summary
✔️ Following Gitflow
✔️ Following Requirements
Optional
All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.
Cheers and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| escape_attempts INT, | ||
| neutered BOOLEAN, |
There was a problem hiding this comment.
[Optional]
- It would be nice if you would pass true or false values to neutered column to use this column correctly because it has a datatype boolean 🤔
| PRIMARY KEY(id) | ||
| ); |
There was a problem hiding this comment.
[Optional]
- It would be nice if you add screenshots in your pull request summary because it is a requirement of your project and it also makes your pull request professional 😊
|
|
||
| <!-- LIVE DEMO --> | ||
|
|
||
| ## 🚀 Live Demo <a name="live-demo"></a> | ||
|
|
||
| > Add a link to your deployed project. | ||
|
|
||
| - [Live Demo Link](<replace-with-your-deployment-URL>) | ||
| - [Live Demo Link](<>) | ||
|
|
There was a problem hiding this comment.
[Optional]
- It would be nice if you remove this Live Demo section from your readme file to make it clean and descriptive 👍 Once you will have your live link then you can add this section again with the live link 😊
|
|
||
| ## 📝 License <a name="license"></a> | ||
|
|
||
| This project is [MIT](./LICENSE) licensed. | ||
|
|
There was a problem hiding this comment.
[Optional]
- Your license link is not working 😨 Kindly fix it to make your readme file descriptive and professional 😊
