Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross library interleaving can cause node 10's nextTick limit to be hit. #399

Closed
stefanpenner opened this issue Dec 7, 2014 · 1 comment

Comments

@stefanpenner
Copy link
Contributor

In node 0.10.x Cross library async interleaving can result in (node) warning: Recursive process.nextTick detected. This will break in the next version of node. Please use setImmediate for recursive deferral.

Although, bluebird typically avoids this with its own micro task queue:

https://github.com/petkaantonov/bluebird/blob/master/src/schedule.js#L5-L9
https://github.com/petkaantonov/bluebird/blob/master/src/async.js#L55-L67

In some scenarios, it is possible to interleave two such micro tasks queues in a way that still results in the limit being hit.

In addition to interleaving between different libraries due to the node_module's dupe friendly module resolution strategy, it is common to have multiple copies of the same library present and interacting with one another.

A quick example:

var A = require('./path/to/rsvp_a').Promise;
var B = require('./path/to/rsvp_b').Promise;

A.resolve().then(function() {
  console.log('first nextTick');
  B.resolve().then(function() {
    console.log('second nextTick');
    A.resolve().then(function() {
      console.log('third nextTick');
    });
  });
});

An example failing test thanks to @taras https://github.com/tildeio/rsvp.js/pull/337/files#diff-e7e77ddad631a023d39a62f3ba8b7f17R2524

this limit has been removed in node 0.11.0

nodejs/node@0761c90
nodejs/node@0761c90

Unfortunately our solution was to fallback to setImmediate in node 0.10.x.

I wasn't able to think of a better solution, but that doesn't mean a better one doesn't exist so if someone has one feel free to share :)

related:
tildeio/rsvp.js#337
cujojs/when#410
kriskowal/asap#51

@stefanpenner stefanpenner changed the title Potential issue on node 0.10.x cross library nextTick interleaving can cause deprecation in node 0.10.x Dec 7, 2014
@stefanpenner stefanpenner changed the title cross library nextTick interleaving can cause deprecation in node 0.10.x Cross library interleaving can cause node 10's nextTick limit to be hit. Dec 7, 2014
@petkaantonov
Copy link
Owner

I'll revisit this if someone has this problem in practice, since it only gives a warning anyway when it happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants