Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append xlsx #475

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@alimanfoo
Copy link
Collaborator

commented Aug 6, 2019

Based on #424, this PR adds tests and deals with table headers.

@alimanfoo alimanfoo referenced this pull request Aug 6, 2019

@alimanfoo alimanfoo added this to the v1.3 milestone Aug 6, 2019

@coveralls

This comment has been minimized.

Copy link

commented Aug 6, 2019

Coverage Status

Coverage decreased (-0.01%) to 89.881% when pulling a85a3fa on appendxlsx into b583865 on master.

@alimanfoo alimanfoo merged commit 4195e3f into master Aug 6, 2019

@alimanfoo

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 6, 2019

Hopefully uncontroversial but happy to revisit if any comments.

@alimanfoo alimanfoo deleted the appendxlsx branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.