Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append xlsx #475

Merged
merged 3 commits into from Aug 6, 2019
Merged

Append xlsx #475

merged 3 commits into from Aug 6, 2019

Conversation

alimanfoo
Copy link
Collaborator

Based on #424, this PR adds tests and deals with table headers.

@alimanfoo alimanfoo mentioned this pull request Aug 6, 2019
Closed
@alimanfoo alimanfoo added this to the v1.3 milestone Aug 6, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 89.881% when pulling a85a3fa on appendxlsx into b583865 on master.

@alimanfoo alimanfoo merged commit 4195e3f into master Aug 6, 2019
@alimanfoo
Copy link
Collaborator Author

Hopefully uncontroversial but happy to revisit if any comments.

@alimanfoo alimanfoo deleted the appendxlsx branch August 6, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alimanfoo @coveralls