Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avro: improve message on schema or data mismatch #507

Merged
merged 6 commits into from
Aug 6, 2020
Merged

avro: improve message on schema or data mismatch #507

merged 6 commits into from
Aug 6, 2020

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Jul 28, 2020 •
edited
Loading

This PR has the objective of helping the developer figure out what row/record has mismatched data with the Avro schema.

Changes

  1. Improved exception handling in toavro()
  2. Added test for exception message

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • Ready to review
    • Ready to merge

@coveralls
Copy link

coveralls commented Jul 28, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.007%) to 91.919% when pulling b301d4d on juarezr:avro_failures into 051320c on petl-developers:master.

@juarezr juarezr requested a review from alimanfoo July 30, 2020 22:51
@juarezr juarezr added the Usability Improvement that benefit petl usage for end users label Jul 30, 2020
@juarezr juarezr mentioned this pull request Aug 4, 2020
Closed
@juarezr
Copy link
Member Author

juarezr commented Aug 6, 2020

I'll merge this PR now because the changes:

  • are in files that I authored.
  • It's restricted to just one component: Avro files
  • doesn't affect public API or previous behavior
  • should not affect working code because it's triggered only when a exception is raised
  • continuous integration checks have passed
  • so it should be low risk
  • any issues can be handled in furthers PR

@juarezr juarezr merged commit d713928 into petl-developers:master Aug 6, 2020
@juarezr juarezr deleted the avro_failures branch September 17, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimanfoo alimanfoo Awaiting requested review from alimanfoo

Assignees
No one assigned
Labels
Usability Improvement that benefit petl usage for end users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juarezr @coveralls