Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese version of kanji #1

Closed
salixh5 opened this issue Oct 21, 2023 · 3 comments · Fixed by #3
Closed

Chinese version of kanji #1

salixh5 opened this issue Oct 21, 2023 · 3 comments · Fixed by #3
Assignees
Labels
bug Something isn't working

Comments

@salixh5
Copy link

salixh5 commented Oct 21, 2023

Generally my Android device is set up correctly for Japanese, but both in the screenshots provided here in the repository as well as on my personal device, kanji are not rendered with their Japanese variant but instead look like Chinese.

Try out 曜 or 直 for some easy to discern examples.

@petlyh petlyh added the bug Something isn't working label Oct 21, 2023
@petlyh
Copy link
Owner

petlyh commented Oct 21, 2023

Thank you for bringing this to my attention. I see now that while kanji displays correctly on my personal device, it does not do so on other devices and on the emulator I used for the screenshots. I think I'll fix it by bundling a Japanese font in the app and either use it for all Japanese text or for the entire app.

@petlyh petlyh self-assigned this Oct 21, 2023
@salixh5
Copy link
Author

salixh5 commented Oct 21, 2023

Interesting. I wonder why, on my device, kanji everywhere are displayed in Japanese variant but not in this app. I'm not experienced with Android but it's unlikely every single app I use has a bundled Japanese font I would guess.

@petlyh
Copy link
Owner

petlyh commented Oct 27, 2023

You are correct that most apps probably don't use a bundled font for this purpose. I believed it to be the only viable solution because of limitations of the Flutter framework that this app uses. However, it turns out that Flutter allows setting the locale used for rendering text, which can be used to fix this problem.

@petlyh petlyh closed this as completed in #3 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants