-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cpp code #84
Add cpp code #84
Conversation
molpopgen
commented
Oct 9, 2018
- Add the code from my repo
- Add a README for this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
fwdpy11_arg_example/TODO.md
Outdated
@@ -0,0 +1,32 @@ | |||
# To get msprime integration working: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe drop this file?
fwdpy11_arg_example/README.rst
Outdated
conda config --add channels bioconda | ||
conda config --add channels conda-forge | ||
conda install gcc fwdpy11==0.1.4 msprime==0.5.0 pybind11==2.2.1 pandas | ||
git clone https://github.com/molpopgen/fwdpy11_arg_example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete next two lines, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or at least, the clone and 'cd' are now redundant. Could say at the start to make sure CWD is where this readme is.
Looks good! We should perhaps explicitly clarify that the example actually does need msprime 0.5.0 to run, and some minor changes would be needed to run with the current version: I just tested it with a more recent version and got
How about
|
Done.
…On Thu, Oct 11, 2018 at 9:38 AM Peter Ralph ***@***.***> wrote:
Looks good! We should perhaps explicitly clarify that the example actually
*does* need msprime 0.5.0 to run, and some minor changes would be needed
to run with the current version: I just tested it with a more recent
version and got
trees.dump_tables(nodes=self.__nodes, edges=self.__edges)
TypeError: dump_tables() got an unexpected keyword argument 'nodes'
How about
**Note:** This code uses msprime version 0.5.0 (installed in the example below using conda). To make it work with a more recent msprime version, some minor changes would be needed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGHnH_tKYwFqNN0ItE2mwsWQYff6OumKks5uj3PFgaJpZM4XTlXT>
.
|
Looks good to me. Thanks Kevin! |
Rad; thanks. |