Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid flow code - #TODO #35

Closed
rodrigomoliveira1 opened this issue Feb 14, 2019 · 5 comments
Closed

Fluid flow code - #TODO #35

rodrigomoliveira1 opened this issue Feb 14, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@rodrigomoliveira1
Copy link
Collaborator

Fluid_flow.py was added in a new branch called "fluid-flow".
Here are some changes that should be made in it.

  • Translate comments, names of variables and functions.

  • Add docstring to explain functions.

  • check PEP 8

  • Remove TODO from the code and add them here

@flaviorangel
Copy link
Collaborator

Comments and names have been translated. The remaining tasks are still pending.

@flaviorangel
Copy link
Collaborator

These TODOs are commented in the fluid flow branch. They are being solved gradually, but this issue won't be closed until this branch is ready to merge, which will depend mostly on the example test issue.

@JuliaMota
Copy link
Collaborator

I checked PEP8 and now it's ok.
Correct documentation details missing.

@flaviorangel
Copy link
Collaborator

I just pushed changes to the entire fluid-flow code, including those related to these TODOs. I ended up adding a new one: the user needs to be able to choose the structure of the internal radius. I think that belongs to a new issue. This one can be closed as soon as the merges are pushed to the master.

@JuliaMota
Copy link
Collaborator

Some graphics need proper titles and subtitles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants