Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible test failure in upcoming Julia version 1.5 #5

Closed
rfourquet opened this issue May 3, 2020 · 1 comment
Closed

possible test failure in upcoming Julia version 1.5 #5

rfourquet opened this issue May 3, 2020 · 1 comment

Comments

@rfourquet
Copy link

A PkgEval run for a Julia pull request which changes the generated numbers for rand(a:b) indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master branch).

Also, you might be interested in using the new StableRNGs.jl registered package, which provides guaranteed stable streams of random numbers across Julia releases.

Apologies if this is a false positive. Cf. https://github.com/JuliaCI/NanosoldierReports/blob/ab6676206b210325500b4f4619fa711f2d7429d2/pkgeval/by_hash/52c2272_vs_47c55db/logs/Duff/1.5.0-DEV-87d2a04de3.log
@racinmat
Copy link
Collaborator

racinmat commented Jan 6, 2021

You are right, tests actually were broken for Julia 1.5.
I fixed it by hardcoding data for Julia 1.5 and older versions separately.

@racinmat racinmat closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@racinmat @rfourquet