Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Item Font - Serif? #4

Closed
m9aertner opened this issue Mar 9, 2021 · 1 comment
Closed

Menu Item Font - Serif? #4

m9aertner opened this issue Mar 9, 2021 · 1 comment

Comments

@m9aertner
Copy link
Contributor

Is it intentional that the Menu Items appear in a serif font when the site default is sans serif?

Please consider themes\hugo-dpsg\assets\css\style.css # .menu__link:

  • Line 3/5 has $fontSans / $fontFamilyPrimary as "Open Sans", Helvetica, Arial, sans-serif
  • Line 633 shows "'Merriweather', Georgia, serif;"
  • Line 450 similar with "address", hard-coded (but visually fine).

I would expect that a theme does not mix serif and sans-serif. I realize that custom CSS files can be configured to override this, and you of course might simply find the current look much better, but from a (non-professional) design point of view I believe the default should be consistent across the whole page, i.e. non-serif.

Feel free to close this issue if that choice was intentional. Also, I did not check the underlying WordPress theme, maybe that's just a setting that was taken over from there faithfully. Otherwise, just deleting CSS line 633 is what I would recommend.

I really appreciate you making your work available publicly. Thanks!
M.

@mxmehl
Copy link
Member

mxmehl commented Mar 9, 2021

Yes, it's intentional in a sense that the same fonts are used on dpsg.de. The headlines in my theme differ a bit (sans instead of serif), but mixing these seemed even less logical to me.

I really appreciate you making your work available publicly. Thanks!

Thank you, and thanks for reporting this issue :)

@mxmehl mxmehl closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants