Mf2 support #17
Merged
Mf2 support #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the plugin should only implement the spec stuff
…-webmention into experimental Conflicts: webmention.php
props to @acegiak
finger->mention
finger->mention
Update readme.txt
Update webmention.php
works for me with 3.8, modulo bugs reported, which should have no bearing on wordpress version at least up to 3.8.
Update readme.txt
and grunt task to convert readme.txt to readme.md
should fix pfefferle#8
thanks to @snarfed for the ideas
* added post-id to `webmention_links` filter * improved `publish_post_hook` function
thanks @acegiak
support multiple rel values like <link rel="webmention http://webmention.org/" /> thanks @snarfed
…thful rendering of the webmention as a comment.
|
Oh man! You have done a lot of work, thanks a lot for that! ...I hope you were aware of the fact, that we only moved the mf2 stuff to another plugin because it is not really part of the webmention spec? https://github.com/pfefferle/wordpress-semantic-linkbacks |
|
Happy to help! I was vaguely aware that it wasn't part of the spec, although it seems that most implementations use it, so it made sense to try. Btw, just figured out how to take advantage of the icon url we've saved, so I've pushed that too.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoint now tries to parse the endpoint for MF2 before falling back to the current method. Also changed the duplicate comment detection.
This lets the webmention more accurately render as a comment.
Also saved the profile icon url against the comment, so themes can use this (or ideally the plugin hooks in and provides this where present, when I work out how)