Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors #3

Closed
pfist opened this issue Sep 10, 2021 · 1 comment
Closed

Handle errors #3

pfist opened this issue Sep 10, 2021 · 1 comment
Assignees
Milestone

Comments

@pfist
Copy link
Owner

pfist commented Sep 10, 2021

Hiei should handle errors with a custom class that extends the native Error object. Read this article from Node Best Practices for guidance.

@pfist pfist added this to the 1.0 milestone Sep 10, 2021
@pfist pfist self-assigned this Sep 10, 2021
@pfist pfist pinned this issue Oct 9, 2021
@pfist
Copy link
Owner Author

pfist commented Oct 14, 2021

I opted not to use a custom error class because for v1, I only really needed it for one error (when the run method isn't implemented on a class). Seemed like a wasted effort, so I'll come back to this in the future when the need arises.

@pfist pfist closed this as completed Oct 14, 2021
@pfist pfist unpinned this issue Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant