Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command registration #5

Closed
3 tasks done
pfist opened this issue Sep 10, 2021 · 1 comment
Closed
3 tasks done

Command registration #5

pfist opened this issue Sep 10, 2021 · 1 comment
Assignees
Milestone

Comments

@pfist
Copy link
Owner

pfist commented Sep 10, 2021

I'm still deciding how to approach this. Should Hiei handle command registration or leave it for the bot to deal with?

I would like to explore the possibility of automating command registration. Essentially: if local commands are different from remote commands, register commands again to keep them updated.

Tasks

  • Move sortBy function to a new HieiUtil utility class
  • Cleaner comparison
  • Better variable names
@pfist pfist added this to the 1.0 milestone Sep 10, 2021
@pfist pfist self-assigned this Sep 10, 2021
@pfist pfist pinned this issue Sep 16, 2021
@pfist
Copy link
Owner Author

pfist commented Sep 16, 2021

I submitted a WIP slash command handler tonight with a first pass and command registry sync. So far it's looking doable. I'm able to compare local commands vs. remote commands, but the arrays aren't sorted identically. Remote commands are in a different order, so I need to figure that out. Maybe sort both arrays alphabetically before comparing?

@pfist pfist closed this as completed in c669efd Sep 18, 2021
@pfist pfist unpinned this issue Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant