-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the hang in train_agent_async
with Tensorboard
#89
Conversation
/test |
|
/test |
Successfully created a job for commit e956064: |
Thanks for running the tests. |
/test |
Successfully created a job for commit d05ffba: |
/test |
Successfully created a job for commit 55e35e1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that this PR resolves #88. Thanks!
This PR proposed a fix for #88
With this change, the
SummaryWriter
works only in a single thread associated with the root process and records are passed to the thread usingmultiprocessing.Queue
, because:SummaryWriter
instantiated in the root process causes a problem when it is used in actor processes (see Actor processes hang intrain_agent_async
whenuse_tensorboard=True
#88);SummaryWriter
is active at a time.