Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes flake errors #104

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Fixes flake errors #104

merged 2 commits into from
Nov 26, 2020

Conversation

ummavi
Copy link
Member

@ummavi ummavi commented Nov 26, 2020

Addresses #99 and #100

A flake update changed the behavior of ignoring E402 (ref). This PR applies the recommended fix and also handles E741s with a variable rename.

@ummavi
Copy link
Member Author

ummavi commented Nov 26, 2020

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit 1e6d7bb:

Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prabhatnagarajan prabhatnagarajan merged commit cc22878 into master Nov 26, 2020
@prabhatnagarajan prabhatnagarajan deleted the fix-flakes branch November 26, 2020 05:43
@muupan muupan added this to the v0.2.0 milestone Dec 14, 2020
@muupan muupan added the testing Changes related to testing/reviewing/CI label Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Changes related to testing/reviewing/CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants