Added tinc package for pfSense 2.3 #149

dmegyesi · 2016-06-12T01:07:29Z

Mostly it's a straight copy of the 2.2 package, added new 2.3 required meta things and converted PHP status page to use Bootstrap panel to show log file lines.

No attempt has been made otherwise to clean up the existing code.

Notes:

There is code checking for pfSense versions < 2.3 which can be probably deleted
I haven't done any extensive functionality tests for the tinc software itself, I was able to start up a basic 1-to-1 VPN setup with it
I'm not sure the logging is set up properly (but I'm not sure it was working well in 2.2 neither): the confusion is about using the clog format and whether a bit more verbose logging should be enabled by default or not

I am willing to work on those issues, but since this doesn't seem to have any major issues perhaps it is OK as a first approximation to get the tinc package working again. If the pull can't be accepted as is, any pointers on how to fix the above issues would be greatly appreciated.

Related forum topic: https://forum.pfsense.org/index.php?topic=109843

fourbytes · 2016-06-16T11:06:39Z

+1

mommmomm · 2016-06-28T13:17:11Z

Thanks for picking this up, dmegyesi, fourbytes. It would have been sad not to have tinc in pfsense.
Hope they pull it soon...

alphaz18 · 2016-07-18T20:35:53Z

Can someone please merge this request? a lot of people have been waiting for it since 2.3 was released. and finally some very kind soul picked it up to maintain, and did all the hard work in making it work properly.

PhilRW · 2016-09-02T00:21:13Z

This would be great to have again.

erasmuswill · 2016-09-09T20:58:52Z

I would love to be able to use this on pfsense

rbgarga · 2016-09-15T13:30:30Z

@dmegyesi can you please include necessary changes to have logfile created accordingly?

dmegyesi · 2016-09-19T07:42:05Z

@rbgarga can you please verify the modification?

poelzi · 2016-11-03T07:06:50Z

is there a problem or can this please be merged ????
I use tinc in production and it works very well

DamiaPoquet · 2016-11-14T10:24:37Z

Can this PR be merged? Tinc is really useful.

DamiaPoquet

Everything seems correct.

dannygp87 · 2016-11-14T10:37:35Z

+1 , please merge this. Thanks!

tsenart · 2016-11-28T10:52:56Z

+1

rbgarga · 2016-12-02T19:20:42Z

security/pfSense-pkg-tinc/Makefile

+DISTFILES=	# empty
+EXTRACT_ONLY=	# empty
+
+MAINTAINER=	dinoex@FreeBSD.org


dinoex@FreeBSD.org will not maintain pfSense package, you can set maintainership to coreteam@pfsense.org

rbgarga · 2016-12-02T19:21:16Z

security/pfSense-pkg-tinc/files/etc/inc/priv/tinc.priv.inc

+	INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+	CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+	ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+	POSSIBILITY OF SUCH DAMAGE.


We moved to APACHE20 license, please modify text accodingly. You can see an example at:
https://github.com/pfsense/FreeBSD-ports/blob/devel/security/pfSense-pkg-sudo/files/etc/inc/priv/sudo.priv.inc#L2

rbgarga · 2016-12-02T19:21:30Z

security/pfSense-pkg-tinc/files/usr/local/pkg/tinc.inc

+	INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+	CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+	ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+	POSSIBILITY OF SUCH DAMAGE.


Fix license text

rbgarga · 2016-12-02T19:23:02Z

security/pfSense-pkg-tinc/files/usr/local/pkg/tinc.inc

+		if ($restart_syslogd) {
+			system_syslogd_start();
+		}
+	}


Remove clear_log_file() copy from here and require_once system.inc, this function is available there

rbgarga · 2016-12-02T19:23:59Z

security/pfSense-pkg-tinc/files/usr/local/pkg/tinc.inc

+	rename("{$configpath}", "{$configpath}.old");
+	safe_mkdir("{$configpath}");
+	safe_mkdir("{$configpath}/hosts");
+	touch("{$configpath}/WARNING-ENTIRE_DIRECTORY_ERASED_ON_SAVE_FROM_GUI");


I don't thing this is necessary, users shoudn't touch config files manually on pfSense at all

rbgarga · 2016-12-02T19:27:54Z

security/pfSense-pkg-tinc/files/usr/local/www/status_tinc.php

+	INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+	CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+	ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+	POSSIBILITY OF SUCH DAMAGE.


Fix license text

rbgarga · 2016-12-02T19:28:47Z

security/pfSense-pkg-tinc/files/usr/local/pkg/tinc.inc

+		$pbietcpath = '/usr/pbi/tinc-' . php_uname("m") . '/local/etc';
+		unlink_if_exists("{$pbietcpath}/tinc");
+		symlink($configpath, "{$pbietcpath}/tinc");
+	}


This whole block can be removed

rbgarga · 2016-12-02T19:29:41Z

security/pfSense-pkg-tinc/files/usr/local/pkg/tinc.xml

+	</copyright>
+	<description>A self-contained VPN solution designed to connect multiple sites together in a secure way.</description>
+	<name>tinc</name>
+	<version>1.2.8</version>


1.2.8 should be replaced by %%PKGVERSION%%

rbgarga · 2016-12-02T19:30:01Z

security/pfSense-pkg-tinc/files/usr/local/pkg/tinc_hosts.xml

+	]]>
+	</copyright>
+	<name>tinchosts</name>
+	<version>1.2.8</version>


1.2.8 should be replaced by %%PKGVERSION%%

rbgarga · 2016-12-02T19:30:41Z

security/pfSense-pkg-tinc/Makefile

+	${INSTALL_DATA} ${FILESDIR}${DATADIR}/info.xml \
+		${STAGEDIR}${DATADIR}
+	@${REINPLACE_CMD} -i '' -e "s|%%PKGVERSION%%|${PKGVERSION}|" \
+		${STAGEDIR}${DATADIR}/info.xml


Other XML files containing macro %%PKGVERSION%% should be added to this REINPLACE_CMD statement so version is automatically added to them

rbgarga · 2016-12-02T19:36:18Z

security/pfSense-pkg-tinc/Makefile

+MAINTAINER=	dinoex@FreeBSD.org
+COMMENT=	pfSense package tinc
+
+LICENSE=	GPLv3


This code is APACHE20 and not GPLv3

…me being

tinc package for pfSense 2.3.x (PR pfsense#149)

…d interface groups

rbgarga · 2016-12-14T13:26:13Z

security/pfSense-pkg-tinc/Makefile

+
+LICENSE=	APACHE20
+
+RUN_DEPENDS=    ${LOCALBASE}/sbin/tincd:security/tinc


Replace spaces by TAB here to silence portlint warnings

rbgarga · 2016-12-14T13:26:32Z

security/pfSense-pkg-tinc/pkg-plist

+www/status_tinc.php
+/etc/inc/priv/tinc.priv.inc
+%%DATADIR%%/info.xml
+@dir /etc/inc/priv


It's missing '@dir /etc/inc' here

rbgarga · 2016-12-14T14:11:11Z

I can take care of these 2 last changes during merge

rbgarga · 2016-12-14T14:21:09Z

Added to 2.4.0 and 2.3.3 snapshots, after more testing it can be added to 2.3.2. Thanks!

hb9cwp · 2017-02-07T10:10:50Z

Any progress in getting tinc into 2.3.2 too?

Feature request #86: Change meaning of "RequiredHeaders" such that header validity is always checked, but messages are only rejected on that basis when the flag is set. Based on a patch from Andreas Schulze. Feature request #127: Log SPF results when rejecting. Requested by Patrick Wagner; patch from Andreas Schulze, follow-up patch from Juri Haberland. Feature request #138: Inculde policy and disposition information in an Authentication-Results comment. Based on a patch from Juri Haberland. Feature request #139: Include the client host name if known in failure reports. Suggested by Roland Turner; patch by Andreas Schulze. Fix bug #95: Assume IPv6 for SPF operations. Patch from Juri Haberland. Fix bug #120: Fix control logic around the SPF result. Reported by Christophe Wolfhugel; patch from Andreas Schulze. Fix bug #122: Don't skip the HELO milter phase when SPF is enabled. Reported by Christophe Wolfhugel. Fix bug #157: Fix logging of implicit authserv-ids. Reported by Andreas Schulze; patch from Juri Haberland. Fix bug #158: Log ignored connections. Patch from Andreas Schulze. Fix bug #160: Fix "SyslogFacility" handling. Patch from Juri Haberland. Fix bug #163: Use a larger buffer for the raw MAIL FROM value. Based on a patch from Andreas Schulze. Fix bug #174: Trim "!" suffixes from reporting addresses. Problem noted by Juri Haberland. Fix bug #186: When reloading the configuration file, the public suffix list was read in with the wrong comment indicator. Patch from Federico Omoto. LIBOPENDMARC: Fix bug #115: Fix type mismatch. Patch from Sebastian A. Siewior via Scott Kitterman. LIBOPENDMARC: Fix bug #121: Fix IPv6 CIDR matching in SPF code. Patch from Christophe Wolfhugel. LIBOPENDMARC: Fix bug #125: Compile time IPv6 fix. Reported by Christophe Wolfhugel. LIBOPENDMARC: Fix bug #131: Fix alignment bug. Patch from Andreas Schulze. LIBOPENDMARC: Fix bug #147: Fix stripping of whitespace from DMARC DNS records. Based on a patch from Job Noorman. LIBOPENDMARC: Fix bug #149: Apply "sp" setting, if present and applicable. Patch from Petr Novak. LIBOPENDMARC: Fix bug #154: Fix "rf" and "fo" processing logic. LIBOPENDMARC: Fix bug #156: Fix variable name. Patch by Andreas Schulze. LIBOPENDMARC: Fix bug #165: Fix logic in checking which SPF identifier was used. Patches from Marco Favero and Juri Haberland. LIBOPENDMARC: Fix bug #167: Don't return "fail" when we should return "none". Patch from Marco Favero. REPORTS: Fix bug #134: Handle SMTP errors correctly. Patch from Andreas Schulze. REPORTS: Fix bug #141: Set the HELO parameter correctly. Reported by Alan Smith; patch from Andreas Schulze. REPORTS: Fix bug #143: Fix logic in table truncation. Reported by Wayne Andersen; patch from Juri Haberland. REPORTS: Fix bug #162: Always report "sp" in aggregate reports. Patch from Juri Haberland. REPORTS: Fix bug #166: Fix report start/end time logic. Patch from Juri Haberland. REPORTS: Fix bug #188: Don't delete inputs too early in opendmarc-reports. Patch from Juri Haberland. TOOLS: Fix bug #161: "Forensic" reports were renamed "Failure" reports. Patch from Andreas Schulze. TOOLS: Fix bug #164: Handle IPv6 test addresses. Reported by Andreas Schulze; patch from Juri Haberland. DOCS: Patch #189: Replace the DMARC RFC with an HTML page referencing the relevant specs, since Debian doesn't consider RFCs to be "free". Patch from Scott Kitterman via Juri Haberland. PR: 220902 Submitted by: Dan Mahoney <freebsd@gushi.org> (maintainer), Lukasz Wasikowski <lukasz@wasikowski.net>

ChangeLog: https://www.nlnetlabs.nl/news/2022/Aug/15/ldns-1.8.3-released/ 1.8.3 2022-08-15 * bugfix #183: Assertion failure with OPT record without rdata. * Fix for syntax error in pyldns 1.8.2 2022-08-12 * bugfix #147: Allow for tabs in whitespace before quoted rdata fields. * bugfix #149: Add some missing [out] annotations to doxygen parameters. * Fix build error on Solaris 10 with inet_ntop redeclaration error. * Fix -U flag with ldns-signzone. * Enable compile of SVCB and HTTPS support by default. * bugfix #179: Free line memory even if zone file parsing fails * bugfix #166: Grow buffer when writing chars and fixed size strings when converting to presentation format, preventing potential assersion errors. * bugfix #46: Print network errors when secure tracing. * EDNS0 Option handling and conversion into presentation format. * bugfix #145: ldns-verify-zone should not call occluded records glue. PR: 265859 Reported by: jaap@NLnetLabs.nl (maintainer)

@sruckh

ChangeLog: Core Using vlucas/valitron for user input validation Bumped FontAwesome to version 6.2.0 (#141) PHP versions 7.4 is now the minimal supported versions, older versions are not supported anymore (#143) extended support for PHP 8.1 (#147) Separated some templates into application/views/templates/partials folder (#144) Removed Composer lock file from git repository To avoid any potential issues for users using different version of PHP, composer.lock has been removed from the Git repo Fixed how MVC is implemented by using psr-15 http-handler (#145) Added router and user authentication middlewares Using single pass psr-15 middleware for application routing and user authentication Disabling user authentication does not display a blank page anymore (#140) Improved how exceptions and errors are handled (#145) PHP errors and exception handler and renderer has been refactored (#148) Instantiate Session instance from the Core Controller (#149) Disabling users authentication does not create a fatalog error nor blank page anymore (#135) Dashboard Breadcrumb navigation is now hidden on home page (Dashboard) Jobs report Fixed error with elapsed time when a job haven't been started yet if a job is in pending status, elapsed time column will display 'n/a' Docker image Provided Docker image on Docker Hub (#153) Documentation Update documentation about deprecated version and general security information (#142) Updated / fixed documentation The FAQ has been fixed / updated Security Added security policy and documented know security vulnerabilities (#135 and #140) Fixed New feature(s) Thanks to @sruckh, @skidoo23 and all community users for their feedback, tests, help and bug reports

Added tinc package for pfSense 2.3

95ddd94

netgate-git-updates added the CLA label Jun 12, 2016

Moving the package to the correct folder

2e91bee

dmegyesi mentioned this pull request Jun 27, 2016

Add syslog support for tinc VPN daemon log files pfsense/pfsense#3023

Closed

Add status output support for tap devices too

a07519f

rbgarga added the question label Sep 15, 2016

Added clog handling by package config

2901fa6

rbgarga removed the question label Sep 19, 2016

DamiaPoquet approved these changes Nov 14, 2016

View reviewed changes

rbgarga requested changes Dec 2, 2016

View reviewed changes

rbgarga self-assigned this Dec 2, 2016

rbgarga added the Changes requested label Dec 2, 2016

rbgarga requested changes Dec 2, 2016

View reviewed changes

doktornotor added 6 commits December 6, 2016 21:30

Fix maintainer and license

60eb194

Fix license

f442354

Fix license

64823dd

Use clear_log_file from system.inc

f8b63ae

Remove obsolete 2.2.x PBI junk

ff750b8

Remove redundant safe_mkdir() and comment out the WTH code for the ti…

4f77bf8

…me being

doktornotor and others added 7 commits December 6, 2016 21:48

Do not hardcode version in XML, fix license

5588b8b

Do not hardcode version, fix license

c385ec4

Fix license

8ea6ee1

Remove useless warning placeholder file

1d3032a

Fix year in copyright header.

5959644

Merge pull request #1 from doktornotor/patch-1

56962d1

tinc package for pfSense 2.3.x (PR pfsense#149)

Adjust package version automatically in all XML files

e271e1b

rbgarga added the question label Dec 12, 2016

Use pkg-tinc interface group name to avoid conflicts with user-define…

560a81f

…d interface groups

rbgarga approved these changes Dec 13, 2016

View reviewed changes

rbgarga added Pending review/testing and removed Changes requested question labels Dec 13, 2016

rbgarga requested changes Dec 14, 2016

View reviewed changes

rbgarga added Changes requested and removed Changes requested labels Dec 14, 2016

netgate-git-updates merged commit 560a81f into pfsense:devel Dec 14, 2016

netgate-git-updates pushed a commit that referenced this pull request Dec 14, 2016

Merge pull request #149 from dmegyesi/pfSense-pkg-tinc

054c4f9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added tinc package for pfSense 2.3 #149

Added tinc package for pfSense 2.3 #149

dmegyesi commented Jun 12, 2016

fourbytes commented Jun 16, 2016

mommmomm commented Jun 28, 2016

alphaz18 commented Jul 18, 2016

PhilRW commented Sep 2, 2016

erasmuswill commented Sep 9, 2016

rbgarga commented Sep 15, 2016

dmegyesi commented Sep 19, 2016

poelzi commented Nov 3, 2016

DamiaPoquet commented Nov 14, 2016

DamiaPoquet left a comment •

edited

Loading

dannygp87 commented Nov 14, 2016

tsenart commented Nov 28, 2016

rbgarga Dec 2, 2016

rbgarga Dec 2, 2016

rbgarga Dec 2, 2016

rbgarga Dec 2, 2016

rbgarga Dec 2, 2016

rbgarga Dec 2, 2016

rbgarga Dec 2, 2016

rbgarga Dec 2, 2016

rbgarga Dec 2, 2016

rbgarga Dec 2, 2016

rbgarga Dec 2, 2016

rbgarga Dec 14, 2016

rbgarga Dec 14, 2016

rbgarga commented Dec 14, 2016

rbgarga commented Dec 14, 2016

hb9cwp commented Feb 7, 2017 •

edited

Loading


		LICENSE= APACHE20

		RUN_DEPENDS= ${LOCALBASE}/sbin/tincd:security/tinc

Added tinc package for pfSense 2.3 #149

Added tinc package for pfSense 2.3 #149

Conversation

dmegyesi commented Jun 12, 2016

fourbytes commented Jun 16, 2016

mommmomm commented Jun 28, 2016

alphaz18 commented Jul 18, 2016

PhilRW commented Sep 2, 2016

erasmuswill commented Sep 9, 2016

rbgarga commented Sep 15, 2016

dmegyesi commented Sep 19, 2016

poelzi commented Nov 3, 2016

DamiaPoquet commented Nov 14, 2016

DamiaPoquet left a comment • edited Loading

Choose a reason for hiding this comment

dannygp87 commented Nov 14, 2016

tsenart commented Nov 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rbgarga commented Dec 14, 2016

rbgarga commented Dec 14, 2016

hb9cwp commented Feb 7, 2017 • edited Loading

DamiaPoquet left a comment •

edited

Loading

hb9cwp commented Feb 7, 2017 •

edited

Loading