Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null unit on status monitoring graph #141

Merged

Conversation

strigona-worksight
Copy link
Contributor

When localStorage is cleared and you add a right axis field that has units other than the main left axis, the units will be "null" due to the tempKey stripping out the "(right axis)" from the key and thus not finding a match in localStorage.
2016-05-19_09-16-37_firefox

@jdillard jdillard self-assigned this Jun 2, 2016
@netgate-git-updates
Copy link

Before this pull request can be accepted you must first sign a CLA as described at https://www.pfsense.org/about-pfsense/#cla. Please read for more details.

@strigona-worksight
Copy link
Contributor Author

Done

@jdillard
Copy link
Contributor

jdillard commented Jun 2, 2016

Thanks! I'll test this out tomorrow, but at a glance it looks like a great catch.

(the bot should auto-update the CLA status in a bit if everything was done correctly)

@netgate-git-updates netgate-git-updates merged commit 675ef74 into pfsense:devel Jun 3, 2016
@strigona-worksight strigona-worksight deleted the status-monitoring branch June 8, 2016 16:59
netgate-git-updates pushed a commit that referenced this pull request Sep 13, 2017
Feature request #86: Change meaning of "RequiredHeaders" such that
	header validity is always checked, but messages are only
	rejected on that basis when the flag is set.  Based
	on a patch from Andreas Schulze.
Feature request #127: Log SPF results when rejecting.  Requested
	by Patrick Wagner; patch from Andreas Schulze, follow-up
	patch from Juri Haberland.
Feature request #138: Inculde policy and disposition information
	in an Authentication-Results comment.  Based on a patch
	from Juri Haberland.
Feature request #139: Include the client host name if known
	in failure reports.  Suggested by Roland Turner;
	patch by Andreas Schulze.
Fix bug #95: Assume IPv6 for SPF operations.  Patch from Juri Haberland.
Fix bug #120: Fix control logic around the SPF result.
	Reported by Christophe Wolfhugel; patch from Andreas Schulze.
Fix bug #122: Don't skip the HELO milter phase when SPF is enabled.
	Reported by Christophe Wolfhugel.
Fix bug #157: Fix logging of implicit authserv-ids.  Reported
	by Andreas Schulze; patch from Juri Haberland.
Fix bug #158: Log ignored connections.  Patch from Andreas Schulze.
Fix bug #160: Fix "SyslogFacility" handling.  Patch from
	Juri Haberland.
Fix bug #163: Use a larger buffer for the raw MAIL FROM value.
	Based on a patch from Andreas Schulze.
Fix bug #174: Trim "!" suffixes from reporting addresses.  Problem
	noted by Juri Haberland.
Fix bug #186: When reloading the configuration file, the public
	suffix list was read in with the wrong comment indicator.
	Patch from Federico Omoto.
LIBOPENDMARC: Fix bug #115: Fix type mismatch.  Patch from
	Sebastian A. Siewior via Scott Kitterman.
LIBOPENDMARC: Fix bug #121: Fix IPv6 CIDR matching in SPF code.
	Patch from Christophe Wolfhugel.
LIBOPENDMARC: Fix bug #125: Compile time IPv6 fix.  Reported by
	Christophe Wolfhugel.
LIBOPENDMARC: Fix bug #131: Fix alignment bug.  Patch from
	Andreas Schulze.
LIBOPENDMARC: Fix bug #147: Fix stripping of whitespace from
	DMARC DNS records.  Based on a patch from Job Noorman.
LIBOPENDMARC: Fix bug #149: Apply "sp" setting, if present and
	applicable.  Patch from Petr Novak.
LIBOPENDMARC: Fix bug #154: Fix "rf" and "fo" processing logic.
LIBOPENDMARC: Fix bug #156: Fix variable name.  Patch by
	Andreas Schulze.
LIBOPENDMARC: Fix bug #165: Fix logic in checking which SPF
	identifier was used.  Patches from Marco Favero and
	Juri Haberland.
LIBOPENDMARC: Fix bug #167: Don't return "fail" when we should
	return "none".  Patch from Marco Favero.
REPORTS: Fix bug #134: Handle SMTP errors correctly.  Patch from
	Andreas Schulze.
REPORTS: Fix bug #141: Set the HELO parameter correctly.
	Reported by Alan Smith; patch from Andreas Schulze.
REPORTS: Fix bug #143: Fix logic in table truncation.
	Reported by Wayne Andersen; patch from Juri Haberland.
REPORTS: Fix bug #162: Always report "sp" in aggregate reports.
	Patch from Juri Haberland.
REPORTS: Fix bug #166: Fix report start/end time logic.
	Patch from Juri Haberland.
REPORTS: Fix bug #188: Don't delete inputs too early in
	opendmarc-reports.  Patch from Juri Haberland.
TOOLS: Fix bug #161: "Forensic" reports were renamed "Failure"
	reports.  Patch from Andreas Schulze.
TOOLS: Fix bug #164: Handle IPv6 test addresses.  Reported by
	Andreas Schulze; patch from Juri Haberland.
DOCS: Patch #189: Replace the DMARC RFC with an HTML page
	referencing the relevant specs, since Debian doesn't
	consider RFCs to be "free".  Patch from Scott Kitterman
	via Juri Haberland.

PR:		220902
Submitted by:	Dan Mahoney <freebsd@gushi.org> (maintainer), Lukasz Wasikowski <lukasz@wasikowski.net>
netgate-git-updates pushed a commit that referenced this pull request Apr 6, 2020
Changes since 1.5.3:

Interface:

    * A redesigned interface that works better for smaller screens (#176)
    * Improved fullscreen mode with an overlaid headerbar (#4)
    * The headerbar and the progress bar now auto-hide, for a distraction-free
      reading experience
    * Various location information, as well as a clock, can now be displayed in
      the footer (#175, #233)
    * A new location popover (Ctrl + L) that shows reading time estimates and
      allows skipping to locations (#155)
    * E-reader style navigation: go to the previous or next page by tapping on
      the left or right part of the view; tap on the middle to toggle header bar
      and progress bar
    * Annotations, bookmarks, and find results now show chapter titles (#162)
    * When looking up words in dictionaries, the query can now be edited (#156)
    * New shortcut for viewing metadata (Ctrl + I) and preferences (Ctrl + ,)
    * A new traditional menubar, which may be displayed depending on the desktop
      environment
    * Option to use a traditional titlebar and menubar instead of a headerbar
      (experimental)

Reading:

    * Continuous scrolling layout
    * Option to show decorative shadows that mimic the appearance of a real book
    * Ability to zoom in and zoom out (#117)
    * Improved image viewer with "save as" option
    * Open copies of a book in new windows (Ctrl + N)
    * Reload book (Ctrl + R)
    * New built-in themes: Gray, Solarized, Gruvbox, Nord

Text selection:

    * Ability to select text across pages
    * Find selected text in book
    * Speak selected text or from the selected location (#141)

Annotations:

    * Spellcheck notes (requires new optional dependency "gspell")
    * Export annotations to Markdown (#180)
    * Options to use custom colors for highlights

For publishers and developers:

    * Support for Apple Books theme attribute, which allows books to detect
      themes without JavaScript (#178)
    * WebKit's developer tools can be enabled

Breaking changes:

    * The settings schemas has been reorganized
    * The format for custom themes has changed
    * Locations are now 1024 characters in size

Bug fixes:

    * Fixed not restoring exact last location
    * Fixed navigation not working with scrolled layout
    * Fixed font size not changing when the book uses absolute-size keywords
      (#173)
    * Fixed text cut off at margin edge (#177)
    * Fixed unable to open books with "#" or "?" in the file name
netgate-git-updates pushed a commit that referenced this pull request Apr 19, 2020
- set update instruction notes on pkg-message

ChangeLog v1.2.0:
    bumped minimum supported Python version to 2.4
    implemented support for property diffs (Tigris #383)
    allow user-configurable cvsgraph display (Tigris #336)
    allow rNNNN syntax for Subversion revision numbers (Tigris #441)
    display revision numbers in CVS tag/branch selector (Tigris #546)
    allow roots to have optional context (#58)
    use a more secure temporary file generator (#159)
    fix problems with make-database and special characters (#141, #182)
    fix bogus default ci_when value in cvsdb (#200)
    standalone query interface removed (#206)
    GUI support (--gui) removed from standalone.py

ChangeLog v1.2.1:
    security fix: escape subdir lastmod file name

PR:		245728
Submitted by:	Yasuhito FUTATSUKI
netgate-git-updates pushed a commit that referenced this pull request Feb 26, 2023
ChangeLog:
Core

Using vlucas/valitron for user input validation
Bumped FontAwesome to version 6.2.0 (#141)
PHP versions
7.4 is now the minimal supported versions, older versions are not supported anymore (#143)
extended support for PHP 8.1 (#147)
Separated some templates into application/views/templates/partials folder (#144)
Removed Composer lock file from git repository
To avoid any potential issues for users using different version of PHP, composer.lock has been removed from the Git repo
Fixed how MVC is implemented by using psr-15 http-handler (#145)
Added router and user authentication middlewares
Using single pass psr-15 middleware for application routing and user authentication
Disabling user authentication does not display a blank page anymore (#140)
Improved how exceptions and errors are handled (#145)
PHP errors and exception handler and renderer has been refactored (#148)
Instantiate Session instance from the Core Controller (#149)
Disabling users authentication does not create a fatalog error nor blank page anymore (#135)
Dashboard

Breadcrumb navigation is now hidden on home page (Dashboard)
Jobs report

Fixed error with elapsed time when a job haven't been started yet if a job
is in pending status, elapsed time column will display 'n/a'
Docker image

Provided Docker image on Docker Hub (#153)
Documentation

Update documentation about deprecated version and general security information (#142)
Updated / fixed documentation
The FAQ has been fixed / updated
Security

Added security policy and documented know security vulnerabilities (#135 and #140)
Fixed
New feature(s)
Thanks to @sruckh, @skidoo23 and all community users for their feedback, tests, help and bug reports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants