Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing portscan UDP protocol and fix typos #138

Closed
wants to merge 1 commit into from

Conversation

Andrew17856
Copy link

Dealing with the issues in https://redmine.pfsense.org/issues/6356

  1. Missing UDP protocol in the port scan settings
  2. Various typos

@netgate-git-updates
Copy link

Before this pull request can be accepted you must first sign a CLA as described at https://www.pfsense.org/about-pfsense/#cla. Please read for more details.

@Andrew17856
Copy link
Author

I signed and returned the CLA on 22 April 2016 by email. Please can you check and confirm.

@Andrew17856
Copy link
Author

Have sent it to you again just now for good measure.

@Andrew17856
Copy link
Author

... and have signed it electronically on the pfSense portal.

@bmeeks8
Copy link
Contributor

bmeeks8 commented Jun 9, 2016

I'm OK with these updates to Snort and thanks again Andew for the contribution.

Bill

@Andrew17856
Copy link
Author

Thanks Bill. My pleasure.

@bmeeks8
Copy link
Contributor

bmeeks8 commented Jul 5, 2016

I incorporated the fixes in this Pull Request into the last Snort GUI package update (version 3.2.9.1_14), so this request can be closed.

@rbgarga rbgarga closed this Jul 5, 2016
netgate-git-updates pushed a commit that referenced this pull request Jun 28, 2017
Changes of 8.7.0 including:
- New: Expose license rules as Licensee::Rule (#148)
- New: Recognize underlined license headers in READMEs (#138, props @pchaigno)
- Fixed: Running licensee against a single file on Windows (#144, props @sschuberth)

There were many more changes, but there is no changelog. You need to consult
https://github.com/benbalter/licensee/releases for a list of all changes.
netgate-git-updates pushed a commit that referenced this pull request Sep 13, 2017
Feature request #86: Change meaning of "RequiredHeaders" such that
	header validity is always checked, but messages are only
	rejected on that basis when the flag is set.  Based
	on a patch from Andreas Schulze.
Feature request #127: Log SPF results when rejecting.  Requested
	by Patrick Wagner; patch from Andreas Schulze, follow-up
	patch from Juri Haberland.
Feature request #138: Inculde policy and disposition information
	in an Authentication-Results comment.  Based on a patch
	from Juri Haberland.
Feature request #139: Include the client host name if known
	in failure reports.  Suggested by Roland Turner;
	patch by Andreas Schulze.
Fix bug #95: Assume IPv6 for SPF operations.  Patch from Juri Haberland.
Fix bug #120: Fix control logic around the SPF result.
	Reported by Christophe Wolfhugel; patch from Andreas Schulze.
Fix bug #122: Don't skip the HELO milter phase when SPF is enabled.
	Reported by Christophe Wolfhugel.
Fix bug #157: Fix logging of implicit authserv-ids.  Reported
	by Andreas Schulze; patch from Juri Haberland.
Fix bug #158: Log ignored connections.  Patch from Andreas Schulze.
Fix bug #160: Fix "SyslogFacility" handling.  Patch from
	Juri Haberland.
Fix bug #163: Use a larger buffer for the raw MAIL FROM value.
	Based on a patch from Andreas Schulze.
Fix bug #174: Trim "!" suffixes from reporting addresses.  Problem
	noted by Juri Haberland.
Fix bug #186: When reloading the configuration file, the public
	suffix list was read in with the wrong comment indicator.
	Patch from Federico Omoto.
LIBOPENDMARC: Fix bug #115: Fix type mismatch.  Patch from
	Sebastian A. Siewior via Scott Kitterman.
LIBOPENDMARC: Fix bug #121: Fix IPv6 CIDR matching in SPF code.
	Patch from Christophe Wolfhugel.
LIBOPENDMARC: Fix bug #125: Compile time IPv6 fix.  Reported by
	Christophe Wolfhugel.
LIBOPENDMARC: Fix bug #131: Fix alignment bug.  Patch from
	Andreas Schulze.
LIBOPENDMARC: Fix bug #147: Fix stripping of whitespace from
	DMARC DNS records.  Based on a patch from Job Noorman.
LIBOPENDMARC: Fix bug #149: Apply "sp" setting, if present and
	applicable.  Patch from Petr Novak.
LIBOPENDMARC: Fix bug #154: Fix "rf" and "fo" processing logic.
LIBOPENDMARC: Fix bug #156: Fix variable name.  Patch by
	Andreas Schulze.
LIBOPENDMARC: Fix bug #165: Fix logic in checking which SPF
	identifier was used.  Patches from Marco Favero and
	Juri Haberland.
LIBOPENDMARC: Fix bug #167: Don't return "fail" when we should
	return "none".  Patch from Marco Favero.
REPORTS: Fix bug #134: Handle SMTP errors correctly.  Patch from
	Andreas Schulze.
REPORTS: Fix bug #141: Set the HELO parameter correctly.
	Reported by Alan Smith; patch from Andreas Schulze.
REPORTS: Fix bug #143: Fix logic in table truncation.
	Reported by Wayne Andersen; patch from Juri Haberland.
REPORTS: Fix bug #162: Always report "sp" in aggregate reports.
	Patch from Juri Haberland.
REPORTS: Fix bug #166: Fix report start/end time logic.
	Patch from Juri Haberland.
REPORTS: Fix bug #188: Don't delete inputs too early in
	opendmarc-reports.  Patch from Juri Haberland.
TOOLS: Fix bug #161: "Forensic" reports were renamed "Failure"
	reports.  Patch from Andreas Schulze.
TOOLS: Fix bug #164: Handle IPv6 test addresses.  Reported by
	Andreas Schulze; patch from Juri Haberland.
DOCS: Patch #189: Replace the DMARC RFC with an HTML page
	referencing the relevant specs, since Debian doesn't
	consider RFCs to be "free".  Patch from Scott Kitterman
	via Juri Haberland.

PR:		220902
Submitted by:	Dan Mahoney <freebsd@gushi.org> (maintainer), Lukasz Wasikowski <lukasz@wasikowski.net>
netgate-git-updates pushed a commit that referenced this pull request Nov 15, 2022
Changelog
General

Fixed Composer dependency problem with smarty/smarty (see #131)
Bumped smarty/smarty to version 4.2.1
Improved support for PHP >= 8.0
Fixed PSR12 code style warnings
Improved testing and code coverage (see #133)
The error page was too verbose, even while not in debug mode (see #134)
Test page

Test page was not checking correctly the permissions on the protected
assets folder (see #136)
Console

The console check command now displays current PHP version (see #137)
Documentation

Documentation has been fixed/updated (see #138)
Added instructions for Lighttpd web server (see #129)
Fixed bug(s)
     disabled
     test page
New feature(s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants