GSoC 2023: Aryan Gupta week 4 #310
Conversation
| .vscode | ||
| get_signatures.sh |
There was a problem hiding this comment.
This needs to be removed when the final PR is created for merging to the pgRouting repository.
| ********************************************************************PGR-GNU*/ | ||
| /*! @file */ | ||
|
|
||
| #ifndef INCLUDE_C_TYPES_path_rtdd_H_ |
There was a problem hiding this comment.
Header Include guards should be all-caps. I guess that clang would report a warning in this case.
| # include <stdint.h> | ||
| #endif | ||
|
|
||
| struct path_rtdd { |
There was a problem hiding this comment.
A better struct naming (and file naming) would be one that has rt (return type) at the end. E.g. path_dd_rt or pathdd_rt.
| @@ -0,0 +1,489 @@ | |||
| /*PGR-GNU***************************************************************** | |||
|
|
|||
| file: driveDist.hpp | |||
| Copyright (c) 2022 Celia Virginia Vergara Castillo | ||
| Copyright (c) 2015 Celia Virginia Vergara Castillo | ||
| vicky at erosion.dev | ||
|
|
||
| Copyright (c) 2023 Aryan Gupta | ||
| guptaaryan1010 AT gmail.com | ||
|
|
||
| Copyright (c) 2020 The combinations_sql signature is added by Mahmoud SAKR | ||
| and Esteban ZIMANYI | ||
| mail: m_attia_sakri at yahoo.com, estebanzimanyi at gmail.com |
There was a problem hiding this comment.
In case you are creating a new file, you need not include the other contributors - just project at pgrouting.org and your email is fine.
| ********************************************************************PGR-GNU*/ | ||
|
|
||
| #ifndef INCLUDE_DRIVERS_DRIVING_DISTANCE_v4drivedist_driver_H_ | ||
| #define INCLUDE_DRIVERS_DRIVING_DISTANCE_v4drivedist_driver_H_ |
There was a problem hiding this comment.
Header include guard should be all-caps
| @@ -27,7 +27,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | |||
|
|
|||
| -- MULTIPLE | |||
| --v3.6 | |||
| CREATE FUNCTION pgr_drivingDistance( | |||
| CREATE FUNCTION pgr_v4drivingDistance( | |||
There was a problem hiding this comment.
Any user facing function (aka, the non-underscored one) should not have v4 prefix. All end-user facing function names should be consistent - they should be named similar to others.
The underscore functions can have any name - e.g. the v4 prefix, because we don't expect the end users to use these functions.
| @@ -53,7 +53,7 @@ ROWS 1000; | |||
|
|
|||
| -- SINGLE | |||
| --v3.6 | |||
| CREATE FUNCTION pgr_drivingDistance( | |||
| CREATE FUNCTION pgr_v4drivingDistance( | |||
| @@ -0,0 +1,229 @@ | |||
| /*PGR-GNU***************************************************************** | |||
| File: drivedist_driver.cpp | |||
Fixes # .
Changes proposed in this pull request:
-added a new structure path_rtdd
-made some new v4 files
-adjusted function names
@pgRouting/admins