Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC 2023] Modifying drivingdistance #2548

Merged
merged 8 commits into from Aug 24, 2023

Conversation

aryan1010
Copy link
Contributor

This PR modifies one existing function:

  • ``pgr_drivingdistance`:
    • Adding one new result column 'depth'.
    • Normalizing the output(Adding start_vid column for single vertex).

This is a final merge PR containing commits from several different PRs combined.

The intermediate PRs made on the GSoC-pgRouting repository are as follows:

Description Pull Requests
pgr_drivingdistance

The wiki page with more details on this project can be found here.

@krashish8
Copy link
Member

Please also update the NEWS and release_notes.rst file, similar to the other GSoC PRs.

Copy link
Member

@robe2 robe2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay aside from the missing news that @krashish8 mentioned.

@aryan1010 aryan1010 changed the base branch from develop to dev-4.0 August 24, 2023 03:06
@aryan1010 aryan1010 changed the base branch from dev-4.0 to develop August 24, 2023 03:06
@aryan1010
Copy link
Contributor Author

aryan1010 commented Aug 24, 2023

@robe2 @krashish8 i have updated news and release_notes

@krashish8
Copy link
Member

krashish8 commented Aug 24, 2023

You don't have to update NEWS manually. Use this script to generate NEWS: tools/release-scripts/notes2news.pl

Also, the release_notes.rst file is not formatted correctly. The links are written in a different way in an rst file (you can refer how other students did). NEWS will resemble markdown format.

Copy link
Member

@krashish8 krashish8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links are written in a different format in rst file: https://sublime-and-sphinx-guide.readthedocs.io/en/latest/references.html#links-to-external-web-pages

I think @Aniket-debug also needs to fix this in the release notes.
Otherwise, this looks good. 🎉

@aryan1010 aryan1010 requested a review from robe2 August 24, 2023 12:11
@robe2
Copy link
Member

robe2 commented Aug 24, 2023

Links are written in a different format in rst file: https://sublime-and-sphinx-guide.readthedocs.io/en/latest/references.html#links-to-external-web-pages

I think @Aniket-debug also needs to fix this in the release notes. Otherwise, this looks good. 🎉

I think @squarege made this mistake too. I'll go ahead and merge this for expediency.

@robe2 robe2 merged commit d2313f7 into pgRouting:develop Aug 24, 2023
13 checks passed
@cvvergara cvvergara added this to the Release 3.6.0 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants