trsp and tsp name change to be more descriptive

[cvvergara]

Change the names to be more descriptive for example:
pgr_travelingSalesman
pgr_turnRestrictions
If someone likes short names they can wrap them on a function.
So, I can wrap it as:
pgr_vv <--- hey in spanish is vendedor viajante

[dkastl]

pgr_travelingSalesperson is gender-neutral ;-)

[cvvergara]

@dkastl
Wow, you got the hidden vv = Vicky Vergara

[cvvergara]

currently TRSP and because of acronym usage, without looking at the documentation do you know what the acronym mean?
https://www.acronymfinder.com/TRSP.html

comparing with a well known acronym (TSP):
https://www.acronymfinder.com/TSP.html
you can find that TSP means Traveling Salesman Problem

So for TSP I am OK with using the acronym.

[cvvergara]

about TRSP

I want to remove the acronym

SP = shortest path, not true with the current implementation
NOTE: all my examples are using the sample data of the documentation

Example: The shortest path from vertex 1 to vertex 1, well there should be no route

SELECT * FROM pgr_trsp(
    $$SELECT id::INTEGER, source::INTEGER, target::INTEGER, cost, reverse_cost FROM edge_table$$,
    1, 1,
    true,
    true,
    $$SELECT 100::float AS to_cost, 25::INTEGER AS target_id, '32, 33'::TEXT AS via_path$$
);

 seq | id1 | id2 | cost
-----+-----+-----+------
   0 |   1 |   1 |    1
   1 |   2 |   4 |    1
   2 |   5 |   8 |    1
   3 |   6 |   9 |    1
   4 |   9 |  16 |    1
   5 |   4 |   3 |    1
   6 |   3 |   2 |    1
   7 |   2 |   1 |    1
   8 |   1 |  -1 |    0
(9 rows)

So being "Shortest Path" a false statement.

Then pgr_TRP, pgr_TR ???

FYI, IDA BTAM WYDKWTM = For your information, I dislike acronyms, because they are meaningless when you don't now what they mean

• TR = https://www.acronymfinder.com/TR.html
• TRP = https://www.acronymfinder.com/TRP.html

the function's name options

1. pgr_turnRestrictionsPath
2. pgr_turnRestrictions

Note that the word "Shortest" is not there any more.
I will open two comments bellow, put your thumbs up to the name of your liking, (or open an issue with another name that you make up.

[cvvergara]

Vote for
pgr_turnRestrictionsPath

[cvvergara]

Vote for
pgr_turnRestrictions

[dkastl]

Since the result is a path, it should be part of the name in my opinion.

What about the little change to pgr_turnRestrictedPath?

[woodbri]

Daniel +1 on pgr_turnRestrictedPath

…

Sent from my iPhone

On Jun 12, 2018, at 11:45 AM, Daniel Kastl ***@***.***> wrote: Since the result is a path, it should be part of the name in my opinion. What about the little change to pgr_turnRestrictedPath? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[robe2]

Sorry for the back and forth voting. I was undecided between pgr_turnRestrictionsPath and pgr_turnRestrictedPath. I still sort of am.

It seems like "Turn Restricted Shortest Path" term is used slightly more than "Turn Restrictions Shortest Path"

e.g you have it here as that
https://github.com/pgRouting/pgrouting/wiki/Turn-Restricted-Shortest-Path-(TRSP)

The docs seem to be a mixed flavor of both, so should be standardized to whatever naming you decide on:

https://docs.pgrouting.org/latest/en/pgr_trsp.html#trsp

[manikanta-kondeti]

+1 pgr_turnRestrictedPath

…

On Fri, 15 Jun 2018 at 10:13 PM, Regina Obe ***@***.***> wrote: Sorry for the back and forth voting. I was undecided between pgr_turnRestrictionsPath and pgr_turnRestrictedPath. I still sort of am. It seems like "Turn Restricted Shortest Path" term is used slightly more than "Turn Restrictions Shortest Path" e.g you have it here as that https://github.com/pgRouting/pgrouting/wiki/Turn-Restricted-Shortest-Path-(TRSP) The docs seem to be a mixed flavor of both, so should be standardized to whatever naming you decide on: https://docs.pgrouting.org/latest/en/pgr_trsp.html#trsp — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#427 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AExSmV-vHpi36mZCZ0eY_BBgqDcpLjoiks5t8-QqgaJpZM4GiYOc> .

[cvvergara]

TRSP remains.
Almost a decade with the acronym been used on pgRouting that I think it is the best choice.
See TRSP family
For the new diversity of functions within this family

[cvvergara]

Forgot to mention, related to #2238