Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c_type] fixing pgr_mst_rt #2034

Closed
wants to merge 5 commits into from
Closed

Conversation

Jayita10
Copy link

@Jayita10 Jayita10 commented Jul 25, 2021

Fixes #1915

Changes proposed in this pull request:

  • modified: include/c_types/pgr_mst_rt.h
  • modified: src/spanningTree/mst_common.cpp

@pgRouting/admins

@Jayita10
Copy link
Author

Please review @cvvergara

@cvvergara
Copy link
Member

It is noticeable that you are using the web to modify the files, that is not the way a developer works.
Please read carefully the instructions on #1893

That been said, if you work on the web, you then need to use the actions to detect what is wrong.
Click on "Details" of a failing run and look for what is wrong for example:
https://github.com/pgRouting/pgrouting/pull/2034/checks?check_run_id=3177551053#step:8:171
Which means that the problem is on include/drivers/spanningTree/kruskal_driver.h which is an .h file, and then you follow the instructions where you add:

typedef struct pgr_mst_rt pgr_mst_rt;

commit and wait to see what the actions say after the change.
and do it over and over until things are ok.

I will mark as draft, please click on "Ready for review" when the actions pass

@cvvergara cvvergara marked this pull request as draft July 28, 2021 02:32
Copy link
Member

@cvvergara cvvergara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment about the changes that need to be done

@cvvergara
Copy link
Member

No progress or comment on this PR.
Closing

@cvvergara cvvergara closed this Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants