Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema Diff ignore grants option #5759

Closed
ddjuric1 opened this issue Jan 18, 2023 · 5 comments
Closed

Schema Diff ignore grants option #5759

ddjuric1 opened this issue Jan 18, 2023 · 5 comments
Assignees
@yogeshmahajan-1903
Labels
EDB Sprint 149 Feature
Milestone
7.6

Comments

@ddjuric1
Copy link

When comparing two schemas on different servers/databases and different name,
can it be possible to ignore grants, like we already can ignore owner?

Regards
@adityatoshniwal
Copy link
Contributor

@ddjuric1 Did you try v6.19? As the owner is ignored, the grants should also be because they're based on owner. This change is included in 6.19.

@ddjuric1
Copy link
Author

ddjuric1 commented Jan 19, 2023 •
edited

@adityatoshniwal I'm using v6.19. I have two servers (same versions) . On both of them I have databases with the same name an with differently named schemas and different owners. As can be seen in the pictures, some objects still shows different attributes because of different owners, and also grants.

Regards

Capture1
Capture2

@akshay-joshi
Copy link
Contributor

@ddjuric1 'Ignore owner' is working fine can you please uncheck/check again and click on the 'Compare' button?
For grants, it seems to duplicate of #5695

@akshay-joshi akshay-joshi mentioned this issue Jan 19, 2023
Closed
@ddjuric1
Copy link
Author

Hi @akshay-joshi

I did as you asked (and more), I turned off "Ignore owner" and click Compare and got all objects from both schemas as different, then, turned on "Ignore owner", click Compare and again got different objects as shown in the above images. The "Ignore grants" option would be useful even if the schemas and owners were the same. Grants are not the same category as Owner.

Regards

@akshay-joshi akshay-joshi added this to the 7.6 milestone Aug 7, 2023
@akshay-joshi akshay-joshi self-assigned this Aug 7, 2023
akshay-joshi added a commit to akshay-joshi/pgadmin4 that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. pgadmin-org#…
05dc3f8 
…5759

2) Added 'Ignore Tablespace' option in the schema diff tool. pgadmin-org#6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. pgadmin-org#6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. pgadmin-org#6651
akshay-joshi added a commit to akshay-joshi/pgadmin4 that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. pgadmin-org#…
9145db8 
…5759

2) Added 'Ignore Tablespace' option in the schema diff tool. pgadmin-org#6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. pgadmin-org#6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. pgadmin-org#6651
akshay-joshi added a commit to akshay-joshi/pgadmin4 that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. pgadmin-org#…
278e698 
…5759

2) Added 'Ignore Tablespace' option in the schema diff tool. pgadmin-org#6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. pgadmin-org#6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. pgadmin-org#6651

Update preferneces documentation and screenshot
akshay-joshi added a commit to akshay-joshi/pgadmin4 that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. pgadmin-org#…
be89a71 
…5759

2) Added 'Ignore Tablespace' option in the schema diff tool. pgadmin-org#6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. pgadmin-org#6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. pgadmin-org#6651

Update preferneces documentation and screenshot

Fixed review comments.
akshay-joshi added a commit that referenced this issue Aug 11, 2023
@akshay-joshi
1) Added 'Ignore Grants' option in the schema diff tool. #5759
3c43aa1 
2) Added 'Ignore Tablespace' option in the schema diff tool. #6004
3) Ensure that Schema Diff comparison results should be displayed in the sorted order. #6595
4) Fixed an issue where the SET directive is excluded from the function header in the schema diff tool. #6651
@yogeshmahajan-1903
Copy link
Contributor

Working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yogeshmahajan-1903 yogeshmahajan-1903

Labels
EDB Sprint 149 Feature
Projects
None yet
Milestone
7.6
Development

No branches or pull requests
4 participants
@akshay-joshi @yogeshmahajan-1903 @adityatoshniwal @ddjuric1